Migrated from: https://dev.bukkit.org/projects/shopkeepers/issues/530

Originally posted by cindy_k (Jul 23, 2017):

We are having an issue with the second trade failing with the Villagers.
We are only using Admin villager shops.
The server is 1.12 with WorldGuard and Griefprevention.
The villagers are in WorldGuard protection region, but are not in a GriefPrevention area.
 
When a player goes to trade, they can get the first trade to work.  If they try to do a second trade, they can't take the item out of the Villager screen.
I created a video of the issue.
https://youtu.be/xwobMykv06w
 
This is very frustrating since it looks like the trade are only working half the time.
 
We have reviewed our config and can't find anything that would restrict players to only one trade at a time. 
 
Thank you for your help!
cindy_k

Originally commented by blablubbabc (Aug 4, 2017):

I see a lot of '[Shopkeepers] Not handling trade: There is no item in the clicked result slot (no trade available).'
Assuming this are your failed trading attempts: There seems to be a discrepancy between what the server thinks there is and what the client sees.
Either some other plugin messes with the merchant inventory (clearing the result slot on the server without updating the inventory view for the client), or the server thinks that the player didn't offer the correct item and does therefore not allow the trade, while the client sees no difference in the offered and required item and therefore the trade-result item seems to become available for the client.
 
I have seen this before for a plugin which was filtering item information before sending the player the item information, in order to hide certain item lore lines (or other item data / attributes).
Does any of your plugin do something similar? Do you have the same issue with other, regular items (in case this 'filtering' only affects those ruple items)? How are you ruple items created in detail?
 
I highly assume this to be the issue of some other plugin interfering.
 
Edit: I see you are running ViaVersion. By taking a quick look into it, it could very likely be that this plugin is causing this issue. It seems that this plugin is doing something similar to what I described above: Intercepting inventory packets and modifiying the outgoing items.
Could verify whether this plugin is causing the issue by temporarily removing it?
Edit2: I wasn't able to reproduce the issue yet, even with ViaVersion installed.
 
If the issue persists, you will have to try it on a fresh server, adding one plugin at a time until it breaks, in order to find the conflicting plugin..
Edited Aug 4, 2017

Originally commented by blablubbabc (Oct 10, 2017):

Closing this ticket as this is probably an issue related to some other plugin. Can't be sure though without more context.

Originally commented by blablubbabc (Aug 1, 2017):

Hey, sorry for the late reply. For some reason I no longer get notifications about new tickets.
 
Anyways, I tried to reproduce this behavior but wasn't able to. I tested with a diamond item with custom lore, display name and glow effect (enchantment with hidden enchantments flag) like shown in the video.
 
Could you temporarily turn on debug mode (/shopkeeper debug), perform the two trades, and report back the console output you get for those? If shopkeepers prevents the trade it should print some debug message.
 
Also, I assume that you left click for both trading attempts? The plugin only allows left clicks, and shift left clicks in the case of admin shopkeepers.

Originally commented by cindy_k (Aug 4, 2017):

We created a log file of the trade failing.
The trades are on the bottom.
 
https://paste.md-5.net/jedapuroga.vhdl
 
Thank you for your help!

Originally closed by blablubbabc (Oct 10, 2017)