Shopkeepers

Shopkeepers

2M Downloads

Restore Expired Hired Shops to "For Hire" State

yurisuika opened this issue ยท 2 comments

commented

This is a request to modify an existing feature of Shopkeepers.

I am using the Set For Hire feature to place around 35 player shops in my server's spawn, charging a certain amount of our physical currency to hire. I have the shops set to expire after a certain amount of time of inactivity. The problem I face with this is that, after a shop expires, I have to both find out about it and then add back in the shop.

The feature that I would like would be an option to have these expired shops restore to their original For Hire state instead of being deleted.

Thank you.

Minecraft 1.12.2
PaperSpigot-1.12.2-b1462.jar
Shopkeepers v2.1.0-beta

commented

Yes I do understand the current mechanics of it, and that issue does include my request. Sorry I did not come across it in my inquiry.

If I could also add to MasterMithrandir's idea... a timer for resetting the rented state to the rentable state that is not dependent on activity. For example, a player purchases a shop and it changes to the For Hire state after 'x' days.

Even if there were no actual renting mechanic (just the purchasing one), the simple act of having shops revert to the For Hire state with either form of timer would be a nice feature. Because it would not change the owner but just force it to the previous For Hire state (with the same cost), the player would be able to recover their shop inventory whether or not they would choose to hire that shop again.

And, as far as I have experienced, the payment for hiring is not given to the current owner, so, whether this is a bug or not, it would not affect my usage of the mechanic haha.

commented

The current 'for hire' feature really means 'for sale', permanently changing the shop's owner.
By 'expiration' you probably mean the current 'remove shopkeeper after x days of inactivity'-feature.

Anyways, this seems to be a duplicate of #3