ShopKeepers - TPS Drops
Opened this issue ยท 14 comments
- Shopkeepers version:
2.2.1 - Spigot version:
PaperSpigot 1.8.8 - R.0.1
Shopkeepers it doing a lot of Scheduler and causing TPS Drops. How i can solve?
I cannot explain how you get those timings. So please try to reproduce your issue on an up-to-date Spigot server and without other plugins.
What u mean on an up-to-date Spigot? My server need to be 1.8.8 or other plugins wont work
Try it without other plugins. A quickly setup local server should suffice for testing whether this is an issue with shopkeeper, or whether it is somehow related to your server and your other plugins.
This is the code that gets triggered on PlayerItemHeldEvent: https://github.com/Shopkeepers/Shopkeepers/blob/master/src/main/java/com/nisovin/shopkeepers/shopcreation/CreateListener.java#L46
There is nothing performance heavy there and I cannot reproduce your timings myself.
So my guess would be that this was either a one-time thing, or its an issue/interference with your server version or other plugins.
That why I suggest you to try out other setups (other server versions, no other plugins), to hopefully track down the specifics of your setup that cause this.
If you are able to consistently reproduce this with some minimal setup (specific server version or interfering plugin), then I can look into how to potentially solve this. Though, if its related to your server version and not an issue on newer versions then there is nothing on my end to do about it.
Closing this as there is nothing I can do with the provided information. I am not able to reproduce these timings. A full timings report of the server might be useful, as well as feedback regarding testing without plugins and testing with different server versions.
Try with only Shopkeepers. If the issue occurs, let me know which exact server build you are using, so that I can try to reproduce the issue.
Looking at the timings, this issue might not be specific to Shopkeepers, if the rest of the server is lagging as well. Also, can you post a link to the full timings for investigation?
All server lag.
server build: https://i.imgur.com/covFnb3.png
Cannot reproduce the lag: https://timings.aikar.co/?id=e5bb9ded9c8c4cd6aa3ab6e860f07e3c
Can you send me a full timings report?
I cant. What it can be?
Can you send me a full timings report?
I can't do anything about it without further information, and you trying different setups. It has to be something specific to your server, since I cannot reproduce your timings.
I cant.
Well, in that case I don't know how to help you..
If you have further information on how to reproduce this on a fresh server, let me know and I will look into it again.
Then maybe some other plugin is interfering. Can you provide a (minimal) list of plugins this can be reproduced with? Are you using any 'analytical' plugins which might be hooking into other plugin's listeners?
On a fresh server with only Shopkeeper no tps drops :(
What it can be? It's a Prison