Shopkeepers update for MC 1.14
hurrgurl opened this issue ยท 12 comments
CraftBukkit version git-Spigot-4d24e36-5193f76 (MC: 1.14) (Implementing A
PI version 1.14-R0.1-SNAPSHOT)
If disable-gravity=true sometimes Shopkeepers don't turn heads when player is near them.
Not quite sure why it only affects some Shopkeepers but not the others.
P.S.
What does this do?
gravity-chunk-range: 4
Spigot has still some issues which need to be fixed before Shopkeepers can properly work on 1.14. This can currently cause entity duplication, so I highly recommend not running Shopkeepers on Spigot 1.14 yet.
Edit: In your particular case / issue: You are probably running Shopkeepers in 'compatibility (fallback) mode', because it hasn't been updated yet for 1.14. In this mode the artificial entity AI (turning towards nearby players) is disabled. That shouldn't have anything to do with your gravity settings. I would expect all entities not turning their heads. If some entities are turning their head, maybe those are duplicated and not actually valid shopkeeper entities anymore (due to the above mentioned issue).
Edit2: The gravity-chunk-range determines the radius in chunks around players in which the custom gravity will get enabled for shopkeeper entities. This should have no effect if you have gravity disabled. This can be increased to improve visual appearance of entities (they don't appear to be floating in the air if the player is still outside that range but can already see them) or reduced to potentially increase performance slightly.
git-Paper-7 (MC: 1.14) (Implementing API version 1.14-R0.1-SNAPSHOT)
All Shopkeepers (about 100) converted to 1.14 from 1.13.2 just fine. Small issues with lore/text formatting on items, but that's to be expected. Nothing that regex can't fix.
disable-gravity=true
Doesn't keep Shopkeepers in the air for me, they fall down. Can you reproduce?
Besides that ALL Shopkeepers function just as expected. Some also turn heads, who knows why. :)
Doing plugin reload or disconnect/reconnect while near shopkeepers makes them notice you.
Small issues with lore/text formatting on items, but that's to be expected.
Can you provide me an example for lore that does not get properly imported on Spigot 1.14? This sounds like something that would need to be fixed in Spigot's item deserialization.
Regarding Shopkeepers for MC 1.14: I am waiting for Spigot to fix some chunk loading related issue (https://hub.spigotmc.org/stash/projects/SPIGOT/repos/craftbukkit/pull-requests/549/). This is planned for after the update to MC 1.14.1.
I will not look into issues regarding running Shopkeepers on MC 1.14 until after I have released an official update.
For anyone interested in experimenting, I have uploaded a snapshot build for MC 1.14:
http://nexus3.cube-nation.de/repository/snapshots/com/nisovin/shopkeepers/Shopkeepers/2.7.0-SNAPSHOT/Shopkeepers-2.7.0-20190508.225429-1.jar
Due to the above mentioned chunk / entity issue, it is not recommended to use this on a production server yet. Also, depending on the changes that will still be made until an official release, it might not be possible to safely migrate from this snapshot version to the final version for MC 1.14.x. So make sure to backup your 1.13.x Shopkeepers data and use this later for the official update to MC 1.14 (instead of using the data created while running this snapshot version)!
Can you provide me an example for lore that does not get properly imported on Spigot 1.14? This sounds like something that would need to be fixed in Spigot's item deserialization.
Item lore might be fixed with the latest update of Spigot: https://hub.spigotmc.org/stash/projects/SPIGOT/repos/craftbukkit/commits/f69095731175a8d77f6c6f973721fa9a7182ff5d
v2.7.0 has been released which provides support for Spigot 1.14.2.
If you run into any issues, or issues mentioned here are not resolved by that version yet, then please create new tickets for these issues and provide detailed information on how to reproduce them. Also make sure that you reproduce them on a fresh and up-to-date Spigot server, in order to ensure that those issues are not related to running an incompatible or snapshot build previously.
Can you give me link ?
items can be taken over during the exchange. the dupe in here.
Can you be more specific and provide steps to reproduce this dupe?
v2.7.0 has been released which provides support for Spigot 1.14.2.
If you run into any issues, or issues mentioned here are not resolved by that version yet, then please create new tickets for these issues and provide detailed information on how to reproduce them. Also make sure that you reproduce them on a fresh and up-to-date Spigot server, in order to ensure that those issues are not related to running an incompatible or snapshot build previously.
Can you give me link ?
https://dev.bukkit.org/projects/shopkeepers/files
It took a few hours for curse staff to review the upload.