Shopkeepers

Shopkeepers

2M Downloads

Citizens shopkeepers are not removed immediately on npc removal

blablubbabc opened this issue ยท 1 comments

commented

Citizens shopkeepers created by creating an npc shopkeeper (not via the trait) do not get deleted immediately when the corresponding npc is removed via /npc remove. For player shops this means that the corresponding chest stays locked because it remains still in use by the shopkeeper.

Cause: We currently only react to npc removals if the npc has the shopkeeper trait (ref: https://github.com/Shopkeepers/Shopkeepers/blob/master/src/main/java/com/nisovin/shopkeepers/shopobjects/citizens/CitizensListener.java#L22).

The shopkeeper is removed on the next plugin reload though, when it detects that the corresponding citizens npc no longer exists.

Shopkeepers created by adding the shopkeeper trait are not affected. Shopkeepers removed via the editor delete button are not affected either.

commented

Should be fixed in v2.10.0.