Trading discounts for certain (groups of) players
blablubbabc opened this issue ยท 0 comments
This has been asked for on Discord, but the exact use case for this features wasn't described in more detail (Why would one want to give certain players certain discounts? Do different groups of players get different discounts? Which trades would be affected by discounts? etc.).
There are also a bunch of aspects and variations of this feature that would need to be considered, such as:
- How would this be conveniently configured inside the shopkeeper editor, without adding too much complexity to the editor?
- Would it make sense to allow normal players to setup discounts for certain players (this would require additional means for players to set up discounts, assign players to them, and assign the discounts to trades or shops).
- Adjusting the discounts of a large number of trades individually might not be practical. It might therefore make sense to manage discounts as separate 'things' and only configure which trade and/or which shopkeeper is affected by which discounts.
- It might also make sense to be able to create discounts that apply to all trades across all (admin / owned) shopkeepers.
- A trade might be affected by multiple discounts: How do these get combined? Are they added together? Or does the largest discount overrides the other ones? Would it make sense to make this dicount combination behavior configurable?
- How exactly are the discounts calculated?
- How are item amounts rounded?
Also, I don't think the Spigot/Bukkit API exposes all aspects of how discounts work for in vanilla villagers yet. So if this were to work and look like vanilla trading discounts, this piece of API would probably need to be added first as well. I am also not sure how easy or possible it is to make these work like the vanilla discounts, because these might have a per-player component to them.
There might also be other alternatives to achieve the goal of offering certain (groups of) players access to discounted trades. For example, it is already possible to create a separate admin shop that can only be accessed by players with a specific permission node.
The effort to look into this trading discounts feature, implement it, and potentially complicate the shopkeeper editor in order to be able to conveniently configure the discounts per trade, and/or per shopkeeper, might not be worth it for this small convenience addition (there are currently more important features to work on).