Error when trying to load trades with custom spawn eggs with modified entity type
Hyronymos-Old opened this issue ยท 6 comments
Preliminaries:
- Shopkeepers version:
latest - Spigot version:
1.18.2
The issue: Offers of a Villiager are getting cleared, after Server restart
The Shopkeepers are made with Citizens (/trait shopkeeper)
Shopkeepers saves.yml: https://pastebin.com/XJT6VyN9
Error: https://pastebin.com/j1ti3h89
Server-Log: https://pastebin.com/pVnUkbMh
Plugin-List: 
Looks like the issue is the iron golem sawn egg, which we create with following command: /minecraft:give @p polar_bear_spawn_egg{display:{Name:'{"text":"Iron Golem Spawnegg","italic":false}'},EntityTag:{id:"minecraft:iron_golem"}} 1
Can you attach your Shopkeepers save.yml file, ideally once from a backup from before the upgrade, and once after the failed upgrade attempt?
Shopkeepers saves.yml: https://pastebin.com/XJT6VyN9
This file does not look like a valid Shopkeepers save.yml file. Instead this might be the save file of one of your other plugins.
This file does not look like a valid Shopkeepers save.yml file. Instead this might be the save file of one of your other plugins.
we already re-created saves.yml, i will recreate it once again without the shopkeeper that makes problems
saves after restart (shopkeeper doesnt have items anymore): https://pastebin.com/sFf5zMF9
saves before restart (shopkeeper works like usal): https://pastebin.com/EUFJfNaH
I haven't tested and compared the save files yet, but regarding the custom spawn egg item that is supposed to spawn a different kind of mob: This is not supported by Spigot currently. Relevant tickets:
Spigot considers spawn egg items with an entity tag as 'legacy' and attempts to automatically 'migrate' them. Since there is no spawn egg item for iron golems, this migration yields an empty item stack, which would then explain why the loading of the shopkeeper trade fails (all trades require a non-empty result item).