https://prnt.sc/FIK7guQadsAp

The underlying issue should have been fixed in the Spigot server now. However, this will not help you for MC 1.20.4, since the fix is only applied to the latest server version for MC 1.20.6.
So keep using the above java settings for now, until you update your server.

@echo Off
title KNW 1.19 PAPER
:x
"C:\Program Files\Java\jdk-19\bin\java.exe" -Xms6144M -Xmx6144M --add-modules=jdk.incubator.vector -XX:+UseG1GC -XX:+ParallelRefProcEnabled -XX:MaxGCPauseMillis=200 -XX:+UnlockExperimentalVMOptions -XX:+DisableExplicitGC -XX:+AlwaysPreTouch -XX:G1HeapWastePercent=5 -XX:G1MixedGCCountTarget=4 -XX:InitiatingHeapOccupancyPercent=15 -XX:G1MixedGCLiveThresholdPercent=90 -XX:G1RSetUpdatingPauseTimePercent=5 -XX:SurvivorRatio=32 -XX:+PerfDisableSharedMem -XX:MaxTenuringThreshold=1 -Dusing.aikars.flags=https://mcflags.emc.gs -Daikars.new.flags=true -XX:G1NewSizePercent=30 -XX:G1MaxNewSizePercent=40 -XX:G1HeapRegionSize=8M -XX:G1ReservePercent=20 -jar paper.jar --nogui
goto x

Paper 1.20.4 Android için Outlookhttps://aka.ms/AAb9ysg edinin
…
________________________________ From: blablubbabc @.> Sent: Friday, May 31, 2024 10:26:34 PM To: Shopkeepers/Shopkeepers @.> Cc: Kurkins @.>; Author @.> Subject: Re: [Shopkeepers/Shopkeepers] DOESNT WORK 1.20.4 (Issue #886) I need more information on how to reproduce this, e.g. which exact server version are you using. — Reply to this email directly, view it on GitHub<#886 (comment)>, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AXC77SEM5EPC45Y5ZP6UB3LZFDFGVAVCNFSM6AAAAABITFSAI6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCNBSHA3DAOJWGE. You are receiving this because you authored the thread.Message ID: @.***>

I cannot reproduce the issue. I tested on the latest 1.20.4 build of Paper (497), with both Shopkeepers 1.20.1 and 1.19.0.

Is there anything else specific to your server or setup? I think to remember that some other user reported this issue as well on Discord, and they mentioned that they resolved it by using certain server startup parameters: -Duser.language=en -Duser.region=EN -Dfile.encoding=UTF-8

However, I was not yet able to reproduce the issue, regardless of the settings I use.

Which region is your server in? Which file encoding are you using by default? Which language is your server using by default?

I am still not sure how those flags resolve the issue, or how to even reproduce it in the first place. Can you figure out what properties java is using by default for these on your system?

you fixed thanks

Maybe java -XshowSettings shows information on that

Okay, I am able to reproduce it with -Duser.language=tr -Duser.region=TR
On both Paper and Spigot. On Paper, I additional get this error: 2024-05-31 23:25:20,076 ServerMain ERROR Rewrite contains an invalid element or attribute "ExtraClassInfoRewritePolicy". Not sure if related.

Update:
Issue is caused by the server performing a locale-specific toLowercase() conversion of the enchamtnent name "PIERCING" when doing an enchantment lookup during item deserialization. For the turkish locale this results in an unepxected result, probably due to special handling of the i character. Seems like this broke the deserialization of any items containing the piercing enchantment in 1.20.4, and probably any other enchantments containing an I character in their name.

This seems to no longer be an issue in 1.20.6 due to some changes to how enchantment item data is loaded.

The same issue might however still affect a few other aspects of the Bukkit API though. Will do some more testing and then report upstream: https://hub.spigotmc.org/jira/browse/SPIGOT-7676

thanks bro

I need more information on how to reproduce this, e.g. which exact server version are you using.