Bug while executing trade
KM-Owner opened this issue ยท 3 comments
Server version: paper 1.21.4 (the latest version)
Shopkeeper version: 2.23.5
EXAMPLE:
If you want to trade to get ONLY orange wool, you will get orange wool and red wool holding the SHIFT key
This only applies to villagers from shopkeepers (in the previously versions holding shift worked the same as in default villagers)
Some players are nervous because they get unwanted trades and lost items
VIDEO AND SCREENSHOT:
https://imgur.com/a/Nmsxxtf
I am using vanilla minecraft 1.21.4 launcher from minecraft.net (without mods and optifine)
Duplicate of #953
For the future, you can just comment on the existing ticket and I then reopen it when new information is available.
As mentioned in the original ticket, I was originally not able to reproduce the issue on a Spigot server. I just tried to reproduce this on a Paper server, and when using the exact same diamong quantity in input slot 1, I am able to reproduce the issue. I also retested on a Spigot server, and am now able to reproduce this there as well.
I also tested this with a customized vanilla villager to see if this behavior applies there as well, but cannot reproduce this there, so I currently assume this issue is Shopkeepers specific.
in the previously versions holding shift worked the same as in default villagers
Do you remember the Shopkeepers version in which this worked differently? I don't remember having made any changes to this logic in a long time.
Edit: Okay, I think I spotted the issue and when it was introduced (f9c4427#diff-e0aa1cbfa11d80a806b3cdaf170cef7301f86b4b9abab6b7ae743c58b2520915)
This issue will be fixed in the next update (no eta yet).
Additionally, we now also abort the trading if the cost items of the active trading recipe have changed, so that players don't accidentally continue trading the same result item but for different costs.