
Make admin shops be able to save earnings in chests or barrels
Closed this issue ยท 8 comments
I think it would be a nice option if we were able to make admin shops have the earnings in a chest/barrel, or atleast be able in the config to make player shops have an infinite supply, or something along the lines
Lets say i want to sell players the ability to make infinite shops so they dont have to be replenishing the items their selling all the time, of course this would have a much bigger price but it would still be a good option
Lets say i want to sell players the ability to make infinite shops so they dont have to be replenishing the items their selling all the time, of course this would have a much bigger price but it would still be a good option
I am not sure I understand the usecase yet. What's the purpose for having player driven shops that allow players to arbitrarily duplicate any items they want?
Lets say i want only admins to be able to acces the shop and it's trades, but like, the player can buy the shop, ask for the trades it wants to have, so the admin checks they are good trades, and the earnings of the shop go to a chest, so the player wont be able to change such trades, only admins, but it would be still able to gain money from it, in a sumary, a admin shop that lets the earnings go into a chest/barrel
Lets say i want only admins to be able to acces the shop and it's trades, but like, the player can buy the shop, ask for the trades it wants to have, so the admin checks they are good trades, and the earnings of the shop go to a chest, so the player wont be able to change such trades, only admins, but it would be still able to gain money from it, in a sumary, a admin shop that lets the earnings go into a chest/barrel
Player shops with infinite supply makes no sense to me, since it allows players to duplicate any items of their liking.
And I still don't see the usecase for admin shops to collect trade cost items in a chest. If this were to be added, the player shouldn't have access to the chest associated with an admin shop, since they are not the "owner" of the shop. And if they would, it would allow them to arbitrarily exploit the admin shop's trades, just like in the case of player shops with infinite supply.
If you want to figure out the trade history for some reason, the trade history feature might be a better feature to built upon.
Maybe what you are asking for is for player to be able to purchase their personal copy of some admin shop, e.g. to have it placed closer to their base or similar. But this wouldn't require a chest collecting items. And to implement this more conveniently, there would be some other features required for this first, such as linking shopkeepers and be able to create shop creation items that spawn some preconfigured shopkeeper. Or if you plan for admins to be involved in the setup anyway, as you have written above, you can also just implement some way for players to request this and then have admins manually setup the admin shop.
I understand your point, it was a suggestion for something I am making in my server with friends, I wanted a sistem that would let them make infinite shops so they wouldn't have to be restocking the shop all the time, but still Benefict for it, I know it wouldn't be the most convinient for more bigger servers, but atleast for the server I have with my friends it would make some sense, it would work as a different type of gameplay than the usual, one more of a having multiple infinite shops so you only beneficts from it, without you having to restock stuff, but I still get your point on the extra benefict or the exploit that could be, maybe it would be good to add it somewhere along in the config, so it's not so easy to exploit in bigger servers
Forgot to add, the trade history could also work really well, I think that would be maybe better than what I was suggesting, for my purpose it would take more time to achieve what I want, but it would still be posible, so it's a really good idea
I think I "decline" this request: I don't see this feature as generally useful enough for me to include in the core plugin. This sound like a request that is very specific to your server and setup. If you are convinced that you want the shops to work like this on your server, you could try to write (or find someone to write) a custom addon plugin that uses the plugin's API to react to the trade events and either adds the cost items of admin shops to some chest, or readds the result items of some player shop to the chest, or periodically restocks the player shop chests or similar. But I won't be looking into this.