
1.21.4 Uspigot version 2.23.8
Closed this issue ยท 16 comments
[11:46:34 INFO]: [Shopkeepers] Opening UI 'trading' for player NoAskers ...
[11:46:35 INFO]: [Shopkeepers] Inventory event (TradeSelectEvent): player=NoAskers, view-type=MERCHANT, view-title=Smederij
[11:46:36 INFO]: [Shopkeepers] Inventory click: player=NoAskers, view-type=MERCHANT, view-title=Smederij, raw-slot-id=0, slot-id=0, slot-type=CRAFTING, shift=false, hotbar key=-1, left-or-right=left, click-type=LEFT, action=PICKUP_ALL, time: 6548207818
[11:46:37 INFO]: [Shopkeepers] Inventory click: player=NoAskers, view-type=MERCHANT, view-title=Smederij, raw-slot-id=13, slot-id=19, slot-type=CONTAINER, shift=false, hotbar key=-1, left-or-right=left, click-type=LEFT, action=PLACE_ALL, time: 6548208444
[11:46:37 INFO]: [Shopkeepers] Inventory click: player=NoAskers, view-type=MERCHANT, view-title=Smederij, raw-slot-id=3, slot-id=9, slot-type=CONTAINER, shift=false, hotbar key=-1, left-or-right=left, click-type=LEFT, action=PICKUP_ALL, time: 6548209006
[11:46:38 INFO]: [Shopkeepers] Inventory click: player=NoAskers, view-type=MERCHANT, view-title=Smederij, raw-slot-id=0, slot-id=0, slot-type=CRAFTING, shift=false, hotbar key=-1, left-or-right=left, click-type=LEFT, action=PLACE_ALL, time: 6548209511
[11:46:39 INFO]: [Shopkeepers] Inventory click: player=NoAskers, view-type=MERCHANT, view-title=Smederij, raw-slot-id=2, slot-id=2, slot-type=RESULT, shift=false, hotbar key=-1, left-or-right=left, click-type=LEFT, action=NOTHING, time: 6548210431
[11:46:39 INFO]: [Shopkeepers] Shopkeeper 11: Not handling trade: There is no item in the clicked result slot (no trade available).
[11:46:40 INFO]: [Shopkeepers] Inventory click: player=NoAskers, view-type=MERCHANT, view-title=Smederij, raw-slot-id=2, slot-id=2, slot-type=RESULT, shift=false, hotbar key=-1, left-or-right=left, click-type=LEFT, action=NOTHING, time: 6548211351
[11:46:40 INFO]: [Shopkeepers] Shopkeeper 11: Not handling trade: There is no item in the clicked result slot (no trade available).
[11:46:40 INFO]: [Shopkeepers] Inventory click: player=NoAskers, view-type=MERCHANT, view-title=Smederij, raw-slot-id=2, slot-id=2, slot-type=RESULT, shift=false, hotbar key=-1, left-or-right=left, click-type=LEFT, action=NOTHING, time: 6548211547
[11:46:40 INFO]: [Shopkeepers] Shopkeeper 11: Not handling trade: There is no item in the clicked result slot (no trade available).
[11:46:40 INFO]: [Shopkeepers] Inventory click: player=NoAskers, view-type=MERCHANT, view-title=Smederij, raw-slot-id=2, slot-id=2, slot-type=RESULT, shift=false, hotbar key=-1, left-or-right=left, click-type=LEFT, action=NOTHING, time: 6548211710
[11:46:40 INFO]: [Shopkeepers] Shopkeeper 11: Not handling trade: There is no item in the clicked result slot (no trade available).
[11:46:40 INFO]: [Shopkeepers] Inventory click: player=NoAskers, view-type=MERCHANT, view-title=Smederij, raw-slot-id=2, slot-id=2, slot-type=RESULT, shift=false, hotbar key=-1, left-or-right=left, click-type=LEFT, action=NOTHING, time: 6548211899
[11:46:40 INFO]: [Shopkeepers] Shopkeeper 11: Not handling trade: There is no item in the clicked result slot (no trade available).
[11:46:40 INFO]: [Shopkeepers] Inventory click: player=NoAskers, view-type=MERCHANT, view-title=Smederij, raw-slot-id=2, slot-id=2, slot-type=RESULT, shift=false, hotbar key=-1, left-or-right=left, click-type=LEFT, action=NOTHING, time: 6548212107
[11:46:40 INFO]: [Shopkeepers] Shopkeeper 11: Not handling trade: There is no item in the clicked result slot (no trade available).
[11:46:41 INFO]: [Shopkeepers] Inventory event (InventoryCloseEvent): player=NoAskers, view-type=MERCHANT, view-title=Smederij
[11:46:41 INFO]: [Shopkeepers] Player NoAskers closed UI 'trading'.
Everytime I restart the server it does not work. Lets say I take out the old items, with the current trade restart the server the items that worked before don't no more.
I checked even more, it can't be my blockregen plugin as they do stuck after restart. Its just that when you're in survival it breaks but in creative it works?
Not handling trade: There is no item in the clicked result slot (no trade available).
In the past, these kinds of issues have been observed in combination with other plugins that mess with the item packets or items in the trades. I.e. if the result item shows on your client, but you get this message on the server log, there is some discrepancy between the client and server state, so something (usually some other plugin) must have messed with the data on the server or with the packets sent between server and client.
Please try to reproduce this without other plugins (especially item or protocol related plugins) and without client side mods.
Alright, can packetevents, and nexo be an issue for this?
Also thanks for the quick getback!
https://www.diffchecker.com/V0o0VG61/
It is still happing but it's moving around items And I think that is the issue.
This is between reboots the tooltip part is moving to an other place making the item break.
The order of the components does not matter for item comparison purposes, only their content.
But there is one item in line 457 whose lore content has changed, which could be a problem with how the lore data is originally created, or with differences to the format between different Spigot/server versions (outside the control of the Shopkeepers plugin).
Also, this difference would simply result in the result item not showing up on the client either, instead of the client-server discrepancy that you reported above.
There seem to be a lot of custom executableitems item. Also try to reproduce your issues without this and related plugins.
According to some other user's report in the past (see https://github.com/Shopkeepers/Shopkeepers-Wiki/wiki/Known-Issues), there might also be a setting in ExecutableItems to prevent merchant trading (cancel-merchant
). Make sure that this is not active. https://docs.ssomar.com/executableitems/configurations/item-configuration/item-restrictions-resistances
Also, your items seem to track some usage "score", which might be one other reason for tiems to not stack or trading to fail.
And if you make changes to the executable item configuration, newly created items might no longer match items already inside shopkeepers.
Hello, I think we resolved the issue our self! We enabled excect match and it and disabled player-convert and it just keeps working now LOL, anyway thanks for you're time!
Hello, I think we resolved the issue our self! We enabled excect match and it and disabled player-convert and it just keeps working now LOL, anyway thanks for you're time!
Good to know! This convert feature doesn't really make sense to be used on the latest server versions, and especially on Paper might break items. I will consider removing this.
However, I still don't see yet how these features could explain the observed trading issue:
- The conversion feature is not altering the items of the shopkeeper, but the items in the inventory of the trading player. And this doesn't explain the observed behavior (server-client discrepancy; "There is no item in the clicked result slot (no trade available)." log message).
- The "exact item matching" makes item comparisons more strict, so this also cannot explain trades suddenly working that weren't working before (it can only block trades that would usually work fine). It also does not explain the client-server discrepancy.