SignShop v4

SignShop v4

992k Downloads

BugFix

Cat7373 opened this issue · 3 comments

commented

// org/wargamer2010/signshop/listeners/sslisteners/SimpleShopProtector.java

@EventHandler(priority = EventPriority.LOWEST)
public void SSBugFix(BlockPlaceEvent event) {、
    Block block = event.getBlock();

    if(block.getType() == Material.SIGN_POST) {
        Location location = block.getLocation();
    //  Player player = event.getPlayer();
    //  player.sendMessage(ChatColor.DARK_GREEN + "you place a signpost(X:" + location.getX() + ", Y:" + location.getY() + ", Z:" + location.getZ() + ").");

        if(Storage.get().getSeller(location) != null) {
        //  player.sendMessage(ChatColor.DARK_GREEN + "fix a bug shop.");
            Storage.get().removeSeller(location);
        }
    }
}
commented

Thanks for submitting this code. Could you perhaps explain why a fix like this is needed? Because I don't see how a shop can still exist when the sign has been removed (unless serious tampering has been done).

commented

The following comes from Google Translate.

我是一个中国人, 英语学的也不是太好, 所以解释起来比较麻烦, 需要使用翻译软件, 所以还是录个视频好了- -
I am a Chinese people learn English is not very good so do some trouble to explain the feeling they still need to use translation software to segment the video of it - -

你可以在任何地方监听这个事件来修复这个Bug- -
As for the repair just anywhere you can listen to this event - -

http://www.cat73.org/ssbug.avi

commented

Hello there, thank you very much for posting the bug report and the fix. I implemented your fix (with a slight adjustment). This is the resulting build: http://69.175.123.170/job/Signshop/65/ and if you click through, you'll find your change implemented with this commit: 0db5ec5
Thanks again :)