Is there gonna be an update using minecraft 1.13 API?
rayhong118 opened this issue · 7 comments
Just wondering if there's gonna be an update for Minecraft 1.13. Thank you for your long time contribution and hope this excellent plugin will keep on!
We are not currently actively developing the plugin. We would be happy for other suitable developers to take it on.
If you can point me to the right files, I can make a fork to make the suitable changes, likely. Chances are, it's just a lack of support for the new JSON format.
I was more asking "which files handle the items?", since I'm observing a
similar issue, and items from 1.12 and earlier are giving erroneous names,
and 1.13 items are completely dysfunctional thus far.
If it's a library dependency issue, then I'll go upstream and see if I can
commit a fix there.
…On Sun, Nov 11, 2018 at 3:21 PM Devinish ***@***.***> wrote:
Sure, what is it you need? The dependencies? Anything else?
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#49 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAw2cm_w9vFevoFFZ9p4qQmBHQOp5Hhrks5uuIatgaJpZM4VSKpU>
.
--
--
~ "Granted, I will not judge my neighbour until I have walked a mile in his
moccasins" - Noble American Saying.
Please note that this E-mail address is occasionally used to send
information that may be sensitive and/or confidential; if you are not the
intended recipient, please immediately discard and destroy any and all
E-mails from this address, and any copies made, digital or physical.
Failure to comply may result in facing legal consequences.
- Joshua Sararas « [email protected] »
Awesome. When I'm finally free from meetings, I'll take a look, and do a
pull request. I don't have an amazing environment for building Java stuff,
so I can't just keep throwing spaghetti at a wall until it sticks.
…On Mon, Nov 12, 2018 at 2:02 AM wargamer ***@***.***> wrote:
@Omio <https://github.com/Omio> SignShop uses two functions to get the
display names for items, that's getName and getDisplayName in this file
<https://github.com/wargamer/SignShop/blob/master/org/wargamer2010/signshop/blocks/SignShopItemMeta.java#L122>
.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#49 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAw2cp4uIBFLFg7b9pOuMVX6nnUw64xPks5uuR0BgaJpZM4VSKpU>
.
--
--
~ "Granted, I will not judge my neighbour until I have walked a mile in his
moccasins" - Noble American Saying.
Please note that this E-mail address is occasionally used to send
information that may be sensitive and/or confidential; if you are not the
intended recipient, please immediately discard and destroy any and all
E-mails from this address, and any copies made, digital or physical.
Failure to comply may result in facing legal consequences.
- Joshua Sararas « [email protected] »
Yes please use https://github.com/wargamer/SignShop/releases/tag/v3.3.4 or later and either regenerate the config or add the different types(OAK_SIGN, OAK_WALL_SIGN,etc) of signs in place of SIGN and WALL_SIGN in the linkables list. If you still need help post a new issue.