Deprecated version matching
bdotsamir opened this issue · 3 comments
Hey Tim,
I was snooping through to see what your method was for reflection on nms 1.20.2 and saw that it isn't yet here, and I saw this line. Paper released a notice the other day that using this method is essentially deprecated, and that the new method that's been around since 2020 is getServer().getMinecraftVersion() (or, for more backwards compatibility since 2011: getServer().getBukkitVersion()).
I opened an issue for this and not a PR because I'm not sure what your priorities are with supporting older versions.
Thanks!
Your issue does not contain a valid output of the /version command and will now be closed and ignored.
Please create a new issue, follow the template and include a valid /version output.
fuck that bot auto closing tickets. my server is already 1.20.2 and
SilkSpawners || ★ Ready to rock! 1.8.8 - 1.20.4 supported ★ 8.0.0
[12:44:36] [Server thread/INFO]: [SilkSpawners] Enabling SilkSpawners v8.0.0
[12:44:36] [Server thread/INFO]: [SilkSpawners] This version of the plugin is NOT compatible with your Minecraft version!
[12:44:36] [Server thread/INFO]: [SilkSpawners] Please check your versions to make sure they match!
[12:44:36] [Server thread/INFO]: [SilkSpawners] Disabling now!
[12:44:36] [Server thread/INFO]: [SilkSpawners] Compatible versions are: [v1_8_R3, v1_11_R1, v1_12_R1, v1_13_R2, v1_14_R1, v1_15_R1, v1_16_R1, v1_16_R2, v1_16_R3, v1_17_R1, v1_18_R1, v1_18_R2, v1_19_R1, v1_19_R2, v1_19_R3, v1_20_R1, v1_20_R3]
[12:44:36] [Server thread/INFO]: [SilkSpawners] Your version is: v1_20_R2
[12:44:36] [Server thread/INFO]: [SilkSpawners] You can disable this check by setting testMCVersion to false in the config!
Protocol version is checked for Paper >=1.20.5: a0edc4d