Simple Voice Chat

Simple Voice Chat

Bukkit Plugins
337k Downloads

Release type is not being updated in Forge

shotah opened this issue · 7 comments

commented

Bug description
Release to Forge are marked as Alpha

Expected
Release to CurseForge are marked as Release

Impact
Unable to filter files properly when implementing automatically pulling from the Forge API.

Current Output*

            ...
            "displayName": "[FORGE][1.18] Simple Voice Chat 1.18-2.1.18",
            "fileName": "voicechat-forge-1.18-2.1.18.jar",
            "releaseType": 3,
            ...

Expected Output*

            ...
            "displayName": "[FORGE][1.18] Simple Voice Chat 1.18-2.1.18",
            "fileName": "voicechat-forge-1.18-2.1.18.jar",
            "releaseType": 1,
            ...

*** Forge API Documentation ***
https://docs.curseforge.com/#tocS_FileReleaseType

commented

I have no idea what you mean. No curseforge release has ever been marked as release.

No Release on CurseForge at all:
image

The file you mentioned is clearly alpha;
image

What you mention as current output (3) is alpha:
image

commented

Oh this is showing only Beta and Alpha. I was looking for the actual words somewhere. But yes your files are not marked as release. Here is an example from Fabric API.
image

Here is Voice Mod(Which is all B for beta):
image

commented

Yes, but where's the bug?

commented

Yes this mod is still in beta.

  • 👍1
commented

Wanted to say again that this is an awesome mod. It's why I'm here looking at it! :)

I was enabling user of itzg/minecraft-server to supply projectIds to have it pull mods, but I wasn't wanting to include Beta or Alpha. Which we yes can make as an option, but in reviewing this none of the mods are marked as release.

Shell script to parse the files and return the Latest Release for the Version Queried.

   PROJECT_FILE=$(jq -n "$project_files" | jq -jc '
      .data|=( map(select(.releaseType==1)) | sort_by(.id) | reverse) | .data[1]')

PR for the addition over at the itzg repo: itzg/docker-minecraft-server#1275

commented

Bug isn't in the mod, maybe that is the confusion. Or is this mod still in Beta and my confusion?

commented

Was able to get this implemented. Your mod was a great help in getting this fleshed out a bit further. :) https://github.com/itzg/docker-minecraft-server#forgeapi-usage-to-use-non-version-specific-projects

  • 👍1