Simple Voice Chat

Simple Voice Chat

337k Downloads

Localization issue: Hardcoded string for "The volume of your own voice" in settings

DomitoriSenshi opened this issue ยท 2 comments

commented

Additional notes

Hello there!

I'm a user of your Voice Chat mod (specifically version voicechat-forge-1.20.1-2.5.30.jar) and I really appreciate the functionality it brings to Minecraft.

I've been working on translating mods into other languages for personal use, and I've encountered an issue with one particular phrase in the mod's settings overlay.

The phrase is: "The volume of your own voice"

You can find it in the in-game menu by navigating through:
Voice Chat Settings -> Adjust Volumes -> Own voice -> The volume of your own voice

I've tried to locate this string in the mod's localization files (e.g., assets/voicechat/lang/en_us.json) after unpacking the JAR, but I was unable to find any corresponding key for it. It appears this phrase might be hardcoded directly into the mod's compiled Java code (.class files), rather than being linked to a translatable key.

Because it seems to be hardcoded, I cannot translate it using standard resource packs and lang.json files.

It would be incredibly helpful if you could consider changing this string to use a localization key. For example, instead of a direct text component, it could be something like:

Component.translatable("voicechat.options.adjust_volumes.own_voice.label")
or
Component.translatable("voicechat.options.adjust_volumes.own_voice_description")

This would allow users to translate this specific setting, making the mod more accessible and user-friendly for players worldwide.

Thank you for your time and for your amazing work on the Voice Chat mod!

Sincerely, Domitori.

Locale code

en_us and others

Translation json

"Own voice",
"The volume of your own voice",
commented

This is not part of Simple Voice Chat. Addons can add custom volume groups, this string is from another mod.

commented

Thanks for the reply. I'll try to find it in other mods.