Offline votes
melinstagibson opened this issue · 12 comments
Could you please add an offline vote event? because how it is now i cant use it for cross-server vote distribution and it fails quite often too :/
i have two servers which i cant connect via bungeecord for obscure reasons so i cant just direct the combined votes of both sites and servers to one server.
so i am trying to make a system where the votes of of the players of server A count to the votes of server B on site B and the ppl get rewarded on server A and vice versa. so i can specialiize one server on site A with the votes of A+B and the other server on site B with the same amount of votes.
not optimal but still better than splitting the votes on both sites
but in that case i need the name of a player that never joined a server in a variable
now that i think about it you are right with the votespam but in that case ill just filter it by the onlne players of the other server
There is already an offline vote event. However I did check on skUnity and for whatever reason it doesnt appear to be there. I will be going through and updating the docs to see what is missing from skUnity.
The syntax is:
offline vote[ing]
Where event-player gets you offline player that voted provided they have been on the server before and event-string gets you the name of the site the vote came from.
Hopefully this help!
ok, thanks for the clarification. is it possible to make it independent from wether a player ever joined or not? because that breaks my neck in this case. Im trying to redirect votes for players that never joined
So for the players that have never joined, the reason why I did it the way I did was to prevent possible spam from voting site. Also from my knowledge I can only return a offline player object if the player has been on the server before which is also where this limitation has come in.
What would you want to do with players that have never joined before?
Any chance i can get you to change the offline vote event to support players that never joined? because that would make more sense, i can always filter it only by players that joined myself but right now i have no choice at all
no idea but the plugin GAListener can handle offline players that never joined as far as i know. That would make it possible for me to just create a on command workaround in skript but thats kinda unreliable i suppose. but maybe the galistener code helps you a bit.
anyways it would be awesome if you could look into adding that, tyvm
So the offline player thing as for as I know is a Spigot thing, however I can look into adding a new event to fix this issue for you. A new update will not come until next week as I am also working on some other features before I push out a new version.
Oh, and if you are at it it might make sense to add an option to discard saved votes for the offline players or turn off the saving entirely in the config.
i might be annoying but the fact that your addon is the only one that can handle votes, which i think should be in the base plugin, makes it an indispensable thing to have. (for me and most likely many many others) So i would greatly appreciate it if you could increase the extent of options we have in working with the votes
All good! Happy to have some feature requests. I can look at adding in all these features for the next update which should be out either this weekend or early next week.
Sorry about the delay, I got busy with other school work. I will be doing my best to get an update out ASAP along with all the 1.11 stuff.
I have added this feature in the latest version of skRayFall, which can be downloaded here. The syntax is:
[on] [raw] vote receive[d]
event-string will give you the players name that voted. Hopefully this helps.