Skript

Skript

743k Downloads

Deprecated test warnings arithmetic expression

TheLimeGlass opened this issue ยท 1 comments

commented

Skript/Server Version

2.8
1.20.1

Bug Description

The one syntax got deprecated and the tests for it were never updated.

Expected Behavior

To not have warnings on Skript's own tests. They need to be updated.

Steps to Reproduce

Run the tests

Errors or Screenshots

[23:27:09 INFO]: [Skript] Line 153: (../../../../../../src/test/skript/tests/syntaxes/expressions/ExprArithmetic.sk)
[23:27:09 INFO]:     This expression was deprecated in favor of the arithmetic expression, and will be removed in the future. Please use that instead. E.g. 'vector(2, 4, 1) + vector(5, 2, 3)'
[23:27:09 INFO]:     Line: assert ({_v1} ++ {_v2}) is (vector(5, 7, 9)) with "{_v1} ++ {_v2} is not vector(5, 7, 9)"
[23:27:09 INFO]:  
[23:27:09 INFO]: [Skript] Line 154: (../../../../../../src/test/skript/tests/syntaxes/expressions/ExprArithmetic.sk)
[23:27:09 INFO]:     This expression was deprecated in favor of the arithmetic expression, and will be removed in the future. Please use that instead. E.g. 'vector(2, 4, 1) + vector(5, 2, 3)'
[23:27:09 INFO]:     Line: assert ({_v1} -- {_v2}) is (vector(-3, -3, -3)) with "{_v1} -- {_v2} is not vector(-3, -3, -3)"
[23:27:09 INFO]:  
[23:27:09 INFO]: [Skript] Line 155: (../../../../../../src/test/skript/tests/syntaxes/expressions/ExprArithmetic.sk)
[23:27:09 INFO]:     This expression was deprecated in favor of the arithmetic expression, and will be removed in the future. Please use that instead. E.g. 'vector(2, 4, 1) + vector(5, 2, 3)'
[23:27:09 INFO]:     Line: assert ({_v1} ** {_v2}) is (vector(4, 10, 18)) with "{_v1} ** {_v2} is not vector(4, 10, 18)"
[23:27:09 INFO]:  
[23:27:09 INFO]: [Skript] Line 156: (../../../../../../src/test/skript/tests/syntaxes/expressions/ExprArithmetic.sk)
[23:27:09 INFO]:     This expression was deprecated in favor of the arithmetic expression, and will be removed in the future. Please use that instead. E.g. 'vector(2, 4, 1) + vector(5, 2, 3)'
[23:27:09 INFO]:     Line: assert ({_v1} // {_v2}) is (vector(0.25, 0.4, 0.5)) with "{_v1} // {_v2} is not vector(0.25, 0.4, 0.5)"

Other

No response

Agreement

  • I have read the guidelines above and affirm I am following them with this report.
commented

I think these should be kept until 2.9, just in case we somehow break them during 2.8.
I suppose a PR could be made now to target dev/feature.