Skript

Skript

Bukkit Plugins
743k Downloads

Reloading all scripts returns green when errors are encountered

EquipableMC opened this issue ยท 1 comments

commented

Skript/Server Version

[16:08:36 INFO]: [Skript] Skript's aliases can be found here: https://github.com/SkriptLang/skript-aliases
[16:08:36 INFO]: [Skript] Skript's documentation can be found here: https://docs.skriptlang.org/
[16:08:36 INFO]: [Skript] Skript's tutorials can be found here: https://docs.skriptlang.org/tutorials
[16:08:36 INFO]: [Skript] Server Version: git-Purpur-2140 (MC: 1.20.4)
[16:08:36 INFO]: [Skript] Skript Version: 2.8.2 (skriptlang-github)
[16:08:36 INFO]: [Skript] Installed Skript Addons: 
[16:08:36 INFO]: [Skript]  - skript-placeholders v1.6.0 (https://github.com/APickledWalrus/skript-placeholders)
[16:08:36 INFO]: [Skript]  - skript-gui v1.3 (https://github.com/APickledWalrus/skript-gui)
[16:08:36 INFO]: [Skript]  - DiSky v4.12.2-beta1
[16:08:36 INFO]: [Skript]  - skript-reflect v2.4 (https://github.com/SkriptLang/skript-reflect)
[16:08:36 INFO]: [Skript]  - SkBee v3.2.1 (https://github.com/ShaneBeee/SkBee)
[16:08:36 INFO]: [Skript]  - SkLogs v1.0.0 (https://github.com/EquipableMC/SkLogs)
[16:08:36 INFO]: [Skript] Installed dependencies: 
[16:08:36 INFO]: [Skript]  - Vault v1.7.3-b131
[16:08:36 INFO]: [Skript]  - WorldGuard v7.0.9+5934e49

Bug Description

When you run /sk reload /foldername/, the green text appears for scripts in, when it should be red since errors were encountered.

Expected Behavior

It's meant to be red.

Steps to Reproduce

Create a folder in skript/scripts
put some broken code in it
run /sk reload /foldername/
green text should appear

Errors or Screenshots

http://cdn.equipable.xyz/u/t5cDGo.png

Other

No response

Agreement

  • I have read the guidelines above and affirm I am following them with this report.
commented

This PR #6150 solved it but it wasn't the best solution. IMO there should be 2 language entires for successfull reloading and failure.