Skript

Skript

743k Downloads

No converter chaining flags don't prevent conversion.

Moderocky opened this issue ยท 0 comments

commented

Skript/Server Version

2.9-dev/feature

Bug Description

If you use the NO_RIGHT_CHAINING (or no_left...) it doesn't prevent an unchecked cast conversion step being done at the right (or left) of the chain.

This means that converters end up being suggested in nonsensical places, for example Block -> InventoryHolder| would actually permit a Block -> Player conversion (since players are inventory holders).
This also means you can often compare completely discrete types that ought to fail. (During testing we managed to get from String to Slot and compare that with a number ๐Ÿ˜” )

Expected Behavior

No-chaining converters shouldn't upcast at the start or downcast at the end, since this is effectively an unchecked conversion step (and the source of a lot of issues).

Steps to Reproduce

t

Errors or Screenshots

No response

Other

No response

Agreement

  • I have read the guidelines above and affirm I am following them with this report.