Can't Spawn a Firework

Question

Can't Spawn a Firework

Dsa-123 opened this issue 7 months ago · 18 comments

Dsa-123 commented 7 months ago

Skript/Server Version

[18:53:08 INFO]: [Skript] Skript's aliases can be found here: https://github.com/SkriptLang/skript-aliases
[18:53:08 INFO]: [Skript] Skript's documentation can be found here: https://docs.skriptlang.org/
[18:53:08 INFO]: [Skript] Skript's tutorials can be found here: https://docs.skriptlang.org/tutorials
[18:53:08 INFO]: [Skript] Server Version: git-Paper-496 (MC: 1.20.4)
[18:53:08 INFO]: [Skript] Skript Version: 2.8.6 (skriptlang-github)
[18:53:08 INFO]: [Skript] Installed Skript Addons: None
[18:53:08 INFO]: [Skript] Installed dependencies:
[18:53:08 INFO]: [Skript]  - Vault v1.7.3-b131
[18:53:08 INFO]: [Skript]  - WorldGuard v7.0.7+216b061

Bug Description

Hello SkriptLang Team,
I've updated my Skript version from 2.7.4 to 2.8.6 recently and it seems that I can't spawn fireworks anymore

Expected Behavior

Expected to spawn a firework

Steps to Reproduce

After enabling Skript effect commands write !spawn firework at player in chat

Errors or Screenshots

No response

Other

No response

Agreement

I have read the guidelines above and affirm I am following them with this report.

sovdeeth · Answer 1 · 2024-06-03T16:14:01.000Z

Sorry, I'm new to GitHub and I couldn't figure out how to try that pull request you mentioned

Click on the link to the PR, then click on the Checks tab, click on the Java 21 tab on the left, then download the skript-nightly under artifacts

sovdeeth · Answer 2 · 2024-06-03T15:56:10.000Z

This is likely the same problem that #6760 fixes. Try that nightly, see if it fixes it.

Dsa-123 · Answer 3 · 2024-06-03T16:05:51.000Z

Sorry, I'm new to GitHub and I couldn't figure out how to try that pull request you mentioned

sovdeeth · Answer 4 · 2024-06-03T16:34:01.000Z

Yeah, looks like we'll have to either force firework particle or firework spark for the particle name. Pickle's aware and will update the PR to fix this too.

APickledWalrus · Answer 5 · 2024-06-03T16:37:11.000Z

I've updated the PR again to remove the firework conflict. If you use the latest build it should work. Let us know if not.

Dsa-123 · Answer 6 · 2024-06-03T16:37:13.000Z

Perfect. I deleted my comment by accident. Thank you so much

Dsa-123 · Answer 7 · 2024-06-03T16:37:45.000Z

I've updated the PR again to remove the firework conflict. If you use the latest build it should work. Let us know if not.

I will test it in few moments

Dsa-123 · Answer 8 · 2024-06-03T16:52:11.000Z

Not working

Dsa-123 · Answer 9 · 2024-06-03T16:56:44.000Z

If you use the latest build it should work. Let us know if not.

Skript Version: 2.8.6-nightly-9326c82 (skriptlang-nightly) is that the latest build?

APickledWalrus · Answer 10 · 2024-06-03T17:13:21.000Z

This should be it https://github.com/SkriptLang/Skript/actions/runs/9353758434

Dsa-123 · Answer 11 · 2024-06-03T17:32:30.000Z

OK I tried that and it still not letting me to spawn fireworks

Dsa-123 · Answer 12 · 2024-06-03T17:36:53.000Z

It doesn't display any error

APickledWalrus · Answer 13 · 2024-06-03T17:36:17.000Z

is it still printing an error?

Dsa-123 · Answer 14 · 2024-06-03T17:38:35.000Z

command test:
    trigger:

        broadcast "Started"
        loop 10 times:

            spawn a firework at player
            broadcast "%last spawned entity%"
            wait 5 ticks

        broadcast "The End"

Dsa-123 · Answer 15 · 2024-06-03T17:43:24.000Z

Also this is what send when using getClass method

Dsa-123 · Answer 16 · 2024-06-03T17:44:59.000Z

I tried to do some debugging because I thought it would be parsing error but no result at all

sovdeeth · Answer 17 · 2024-06-03T18:08:54.000Z

Seems to be due to FIREWORK_ROCKET being marked as non-spawnable by Bukkit, while clearly being able to be spawned.

APickledWalrus · Answer 18 · 2024-06-06T16:51:22.000Z

@Dsa-123 Are you able to test with the latest nightly build from #6764? It should resolve this issue.

Share to