Skript

Skript

743k Downloads

Weather expression does not work with world variables

ShaneBeee opened this issue ยท 3 comments

commented

Skript/Server Version

[15:48:01 INFO]: [Skript] Skript's aliases can be found here: https://github.com/SkriptLang/skript-aliases
[15:48:01 INFO]: [Skript] Skript's documentation can be found here: https://docs.skriptlang.org/
[15:48:01 INFO]: [Skript] Skript's tutorials can be found here: https://docs.skriptlang.org/tutorials
[15:48:01 INFO]: [Skript] Server Version: 1.20.6-130-5d8e53d (MC: 1.20.6)
[15:48:01 INFO]: [Skript] Skript Version: 2.8.6 (selfbuilt-unknown)
[15:48:01 INFO]: [Skript] Installed Skript Addons: 
[15:48:01 INFO]: [Skript]  - skNoise v1.0.1
[15:48:01 INFO]: [Skript]  - skript-reflect v2.4 (https://github.com/SkriptLang/skript-reflect)
[15:48:01 INFO]: [Skript]  - SkBee v3.5.2 (https://github.com/ShaneBeee/SkBee)
[15:48:01 INFO]: [Skript]  - SkBriggy v1.3.1
[15:48:01 INFO]: [Skript] Installed dependencies: 
[15:48:01 INFO]: [Skript]  - Vault v1.7.3-b131

Bug Description

I recently noticed the weather expression does not work with world variables.

Expected Behavior

It should work with variables

Steps to Reproduce

2 issues here:

command /test:
	trigger:
		set {_w} to world of player
		set weather in {_w} to rain

produces the following error:

[15:48:50 INFO]: Line 61: (test.sk)
[15:48:50 INFO]:     weather type within {_w} can't be set to anything
[15:48:50 INFO]:     Line: set weather in {_w} to rain

it doesn't appear to like weather in which im assuming is a class with the (%*type%|value[s]) (within|in) %~objects% expression.

second:

command /test:
	trigger:
		set {_w} to world of player
		set weather of {_w} to rain

This one simply just does nothing

Errors or Screenshots

No response

Other

No response

Agreement

  • I have read the guidelines above and affirm I am following them with this report.
commented

for the first issue, I think it would be pretty simple to just disallow weather as a classinfo in the values within expression. I doubt anyone is ever trying to do that lol.

commented

The second is conflicting with the [custom] weather of %players% syntax. @Moderocky want to make an AnyWeather type?

commented

The second is conflicting with the [custom] weather of %players% syntax. @Moderocky want to make an AnyWeather type?

Sure, but it might take me some time to get around to it so you're welcome to add it yourself.