Skript

Skript

Bukkit Plugins
743k Downloads

ExprSkull - Not giving texture to skull

GStudiosX2 opened this issue · 6 comments

commented

Skript/Server Version

[23:20:58 INFO]: [Skript] Skript's aliases can be found here: https://github.com/SkriptLang/skript-aliases
[23:20:58 INFO]: [Skript] Skript's documentation can be found here: https://docs.skriptlang.org/
[23:20:58 INFO]: [Skript] Skript's tutorials can be found here: https://docs.skriptlang.org/tutorials
[23:20:58 INFO]: [Skript] Server Version: 1.21.1-13-7c9240f (MC: 1.21.1)
[23:20:58 INFO]: [Skript] Skript Version: 2.9.2 (skriptlang-github)
[23:20:58 INFO]: [Skript] Installed Skript Addons:
[23:20:58 INFO]: [Skript]  - skNoise v1.0
[23:20:58 INFO]: [Skript]  - skript-gui v1.3 (https://github.com/APickledWalrus/skript-gui)
[23:20:58 INFO]: [Skript]  - skript-reflect v2.5.1 (https://github.com/SkriptLang/skript-reflect)
[23:20:58 INFO]: [Skript]  - Hippo v1.2
[23:20:58 INFO]: [Skript]  - SkBee v3.6.1 (https://github.com/ShaneBeee/SkBee)
[23:20:58 INFO]: [Skript]  - Skript-Packet v2.3.0 (www.github.com/Anarchick/skript-packet)
[23:20:58 INFO]: [Skript]  - skript-advancements v1.6.3
[23:20:58 INFO]: [Skript] Installed dependencies: None

Bug Description

I'm not sure since what version but I remember it since 1.21 at least but ExprSkull only gives default skulls even if you use the offlineplayer function with true
Screenshot_20240911-231638
For example Skript-reflect works
Screenshot_20240911-231911
And same as Skbee nbt it works as well!

Expected Behavior

ExprSkull to give the correct skull with the owning player specified

Steps to Reproduce

  1. Open a server with Skript
  2. Enable effect commands if it isn't
  3. Run !give me skull of offlineplayer("Notch", true)

Errors or Screenshots

No response

Other

No response

Agreement

  • I have read the guidelines above and affirm I am following them with this report.
commented

well, the important thing is is that it doesn't work if you use skript syntax

  • 👍1
commented

can reproduce on latest dev/patch

commented

can reproduce on latest dev/patch

I have found out though that the code that did work only works in effect commands because there's time between typing commands but in a actual script it doesn't work without a delay before giving the item ExprSkull still doesn't work though even with a delay

commented

can reproduce on latest dev/patch

I have found out though that the code that did work only works in effect commands because there's time between typing commands but in a actual script it doesn't work without a delay before giving the item ExprSkull still doesn't work though even with a delay

wdym

commented

can reproduce on latest dev/patch

I have found out though that the code that did work only works in effect commands because there's time between typing commands but in a actual script it doesn't work without a delay before giving the item ExprSkull still doesn't work though even with a delay

wdym

set {_i} to 1 of player skull
set {_im} to {_i}.getItemMeta()
{_im}.setOwningPlayer({_player})
{_i}.setItemMeta({_im})
wait 1 tick
give player {_i}

this works in a script but

set {_i} to 1 of player skull
set {_im} to {_i}.getItemMeta()
{_im}.setOwningPlayer({_player})
{_i}.setItemMeta({_im})
give player {_i}

does not

commented

After testing some stuff myself since this was brought up again in help channels, the alternative fix without doing that wait is through Bukkit.createPlayerProfile() and using SkullMeta#setPlayerProfile(), not saying it's the best fix but the deprecation of the method is paper for no clear reason aside maybe the lookups.

Also can we get a priority tag set for this since imo it's not really lowest or low it's a pretty used expression

Using OfflinePlayer#getPlayerProfile() didn't appear to work for me when I tried it and forced the bukkit method

  • 👍1