Skript

Skript

Bukkit Plugins
743k Downloads

UpdateChecker - GithubChecker/ReleaseChannel Improper checks

Fusezion opened this issue ยท 0 comments

commented

Skript/Server Version

[04:06:32 INFO]: [Skript] Skript's aliases can be found here: https://github.com/SkriptLang/skript-aliases
[04:06:32 INFO]: [Skript] Skript's documentation can be found here: https://docs.skriptlang.org/
[04:06:32 INFO]: [Skript] Skript's tutorials can be found here: https://docs.skriptlang.org/tutorials
[04:06:32 INFO]: [Skript] Server Version: 1.21.3-81-da71382 (MC: 1.21.3)
[04:06:32 INFO]: [Skript] Skript Version: 2.10.0-beta1 (skriptlang-github)
[04:06:32 INFO]: [Skript] Installed Skript Addons:
[04:06:32 INFO]: [Skript]  - skript-gui v1.3 (https://github.com/APickledWalrus/skript-gui)
[04:06:32 INFO]: [Skript]  - Skuishy v2.8.1 (https://aabss.cc)
[04:06:32 INFO]: [Skript]  - skript-reflect v2.5.1 (https://github.com/SkriptLang/skript-reflect)
[04:06:32 INFO]: [Skript] Installed dependencies:
[04:06:32 INFO]: [Skript]  - Vault v1.7.3-b131

Bug Description

When skript releases a new version and the user is currently using a beta/alpha/prerelease ReleaseChannel the channel's ReleaseChannel#check method will always default to True since that allows non-stable releases.

However when skript makes a release for an older version say 2.9.5 after said beta when GithubChecker runs through their releases they always set the first release at the "latest" release

Skript/src/main/java/ch/njol/skript/update/GithubChecker.java

Lines 129 to 132 in 7b5a8a6

// Check if this is a suitable latest release
if (latest == null && channel.check(name)) {
latest = release;
}

Expected Behavior

Skript to properly check against Version hopefully using their own Version class

Steps to Reproduce

Run skript-2.10.0-beta1 on any supported server version

Errors or Screenshots

image

Other

No response

Agreement

  • I have read the guidelines above and affirm I am following them with this report.