Skript

Skript

743k Downloads

Block sound expression ending loops

SoITheIdiot opened this issue ยท 11 comments

commented

Skript/Server Version

[Skript] Skript's aliases can be found here: https://github.com/SkriptLang/skript-aliases
[Skript] Skript's documentation can be found here: https://docs.skriptlang.org/
[Skript] Skript's tutorials can be found here: https://docs.skriptlang.org/tutorials
[Skript] Server Version: 1.21.3-81-da71382 (MC: 1.21.3)
[Skript] Skript Version: 2.10.0-beta1 (skriptlang-github)
[Skript] Installed Skript Addons:
[Skript] - SkBee v3.6.4 (https://github.com/SkriptHub/SkBee)
[Skript] Installed dependencies:
[Skript] - WorldGuard v7.0.13-beta-1+2f13ae0

Bug Description

Upon use of the Block Sound expression in Skript 2.10.0 with the server version 1.21.3 it provides no error, yet stops loops it is used in.

Expected Behavior

Expected Behaviour of the block sound expression was to return the block sound of a block given in the line it is placed in.

Steps to Reproduce

command /test:
    trigger:
        send "a"
        play sound (hit sound of block below player) at player to all players
        send "b"

Errors or Screenshots

image
The image attached shows a file being reloaded, then the command shown above used to reproduce the error being executed.

Other

No response

Agreement

  • I have read the guidelines above and affirm I am following them with this report.
commented

you'll have a console stracktrace can we get that

commented

My best guess is, since they're running 2.10 beta-1, it doesn't contain the fix for Sound Utils/Sound Class. As both the patch PR and feature PR were merged after 2.10 beta-1 was released.
The fix is available in 2.9.5 though

commented

I did try the thing in 1.20.1 iirc, it did function then

commented

That's because 1.21.3 is when Bukkit changed the Sound class from an enum to an interface. Thus causing the issue.

commented

My best guess is, since they're running 2.10 beta-1, it doesn't contain the fix for Sound Utils/Sound Class. As both the patch PR and feature PR were merged after 2.10 beta-1 was released. The fix is available in 2.9.5 though

That's because 1.21.3 is when Bukkit changed the Sound class from an enum to an interface. Thus causing the issue.

Ah i see, that makes sense. Then they most likely don't have the patch for it, causing the problem.

commented

Well the patch is on Skript's end, on how it accesses the Sound class. The patch to fix the issue was completed after 2.10 beta-1 was released. So currently the only version that has the fix is 2.9.5

commented

you'll have a console stracktrace can we get that

org.bukkit.command.CommandException.txt
I couldnt quite get the extra 27 lines, but this is what i managed to get from my server logs.

commented

Well the patch is on Skript's end, on how it accesses the Sound class. The patch to fix the issue was completed after 2.10 beta-1 was released. So currently the only version that has the fix is 2.9.5

So i suppose i'll have to wait for 2.10 beta-2 or find some workaround using an addon such as skript-reflect?

commented

You can do whichever, if you need it now you can attempt Skript-Reflect. 2.10 prerelease is in like 2 weeks

commented

You can do whichever, if you need it now you can attempt Skript-Reflect. 2.10 prerelease is in like 2 weeks

I think i can probably wait that long and just put a placeholder sound in the meantime

commented

To be more accurate
2.10 prerelease comes out Jan 1st
2.10 official release comes out Jan 15th