Skript/Server Version

[20:00:06 INFO]: [Skript] Skript's aliases can be found here: https://github.com/SkriptLang/skript-aliases
[20:00:06 INFO]: [Skript] Skript's documentation can be found here: https://docs.skriptlang.org/
[20:00:06 INFO]: [Skript] Skript's tutorials can be found here: https://docs.skriptlang.org/tutorials
[20:00:06 INFO]: [Skript] Server Version: 1.21.5-103-2ba1675 (MC: 1.21.5)
[20:00:06 INFO]: [Skript] Skript Version: 2.11.2 (skriptlang-github)
[20:00:06 INFO]: [Skript] Installed Skript Addons: None
[20:00:06 INFO]: [Skript] Installed dependencies: None

Bug Description

Title

Expected Behavior

Title

Steps to Reproduce

command /test:
	trigger:
		set {_effects::*} to all potion effect types
		loop {_effects::*}:
			if loop-value is bad omen or raid omen:
				add loop-value to {_output::*}
		send "%{_output::*}%"

Sends bad omen and bad omen

Errors or Screenshots

No response

Other

No response

Agreement

• I have read the guidelines above and affirm I am following them with this report.

Likely due to the fact the first option for raid omen is bad omen - likely a compatibility measure for cross-version support. However, I don't think it would be a problem to swap the ordering so that the toString is raid omen

I am a little curious about how apply bad omen to player (or comparisons) works (as in, the option it would pick)

I'm a bit confused on what the compatibility concerns were. bad omen it self still exists just had two additional separated types for trial omen and raid omen

So how exactly did adding it into raid omen solve anything?

Looks like starting in 1.20.5, BAD_OMEN had started supporting events for trial chambers, then 1.21 RAID_OMEN was added I guess to be like how BAD_OMEN used to be, which was only for villages

Even then the compatibility concern isn't necessary I don't believe, since bad omen itself once drank will tick checking to see if they're in a village or trial chamber not immediately decide, adding bad omen onto raid omen could of caused more issues if that took precedence when giving potion effects.

Adding it onto raid omen at all is a concern

Oh, it looks like I am the one who added it. I agree it was a mistake and that the solution here is to remove bad omen as an option for raid omen

Good First Issue Guide

To resolve this issue, you will want to edit the default.lang file. Under potion effect types, remove bad omen as an option for raid_omen. That is:
old: raid_omen: bad omen, raid omen
new: raid_omen: raid omen