Slimefun

Slimefun

3M Downloads

performance impact from oil pump in standby?

mrcoffee1026 opened this issue ยท 4 comments

commented

Description (Required)

Doing an sf timings reported a 59 second hit by a single Oil Pump. I investigate that oil pump and it has power, has collected the oils from that chunk already and is then just sitting empty in that chunk while the player's remaining devices (like the geo miner) continue to run. The server was reporting tps 15 so I had them mine the oil pump and it immediately shot back up to 20 tps. This should not be normal for this device while it is essentially in "standby".

Steps to reproduce the Issue (Required)

Leave an oil pump or two finished and powered up within chunks loaded on the server and inspect timings. I'm god similar 59 second reports from Geo Scanners last night. All but 2 of the ones installed on the server were done. I mined them all and put them into chests for those players but that did not help with the lag any, although it did remove them from the sf timings report.

Expected behavior (Required)

Would expect there to be no significant timings coming from inactive (finished) Oil Pumps or Geo Miners.

Server Log / Error Report

No Log Activity.

Environment (Required)

[13:31:29 INFO]: Paper v1_14_R1
[13:31:29 INFO]:
[13:31:29 INFO]: CS-CoreLib vDEV - 78 (git 199e1b1e)
[13:31:29 INFO]: Slimefun vDEV - 323 (git 57e1126)
[13:31:29 INFO]:
[13:31:29 INFO]: Installed Addons (13)
[13:31:29 INFO]: Barrels vDEV - 7 (git 0d14dd9f)
[13:31:29 INFO]: SlimeXpansion vDEV - 4 (git 5bf10c29)
[13:31:29 INFO]: ExtraGear vDEV - 3 (git de222ab7)
[13:31:29 INFO]: ChestTerminal vDEV - 17 (git 933a7d36)
[13:31:29 INFO]: EmeraldEnchants vDEV - 5 (git 6adbbb87)
[13:31:29 INFO]: HotbarPets vDEV - 20 (git cd87bc60)
[13:31:29 INFO]: ExoticGarden vDEV - 22 (git a855f5b7)
[13:31:29 INFO]: SoulJars vDEV - 4 (git 4a600aa2)
[13:31:29 INFO]: SlimefunOreChunks vDEV - 2 (git 24d90a3e)
[13:31:29 INFO]: ElectricSpawners vDEV - 5 (git c3f8cc9d)
[13:31:29 INFO]: ExtraHeads v1.1
[13:31:29 INFO]: PrivateStorage vDEV - 6 (git b012877e)
[13:31:29 INFO]: DyedBackpacks vDEV - 1 (git 4b4d1f0f)

As all things performance related are exceedingly difficult to test or to prove, I don't expect much out of this ticket but if both of those blocks could be given a once-over, our overall TPS would greatly appreciate it.

commented

Would be great if you actually showed that timings report instead of just talking about it out of thin air.

commented

don't believe there's a way to copy the hover-over values.

commented

Screenshot, run it via console or in the worst case... Copy them one-by-one...

commented

here's one of it happening with build 340:
https://imgur.com/a/VE0sFuG
There may be other geo miners but the huge numbers went away after breaking the one placed oil pump on the entire server... which was done with the current chunk and had an empty inventory and the one geo miner which was "finished" status and still had all the ore blocks it collected in its inventory. After I broke these two blocks and placed them in chests the timing looked fairly normal and tps gradually went back to normal.