Slimefun

Slimefun

Bukkit Plugins
3M Downloads

Guide glitch again...

poma123 opened this issue · 1 comments

commented

Description (Required)

The Lava generator is now okay, we can not take that out. But the Nuclear reactor still do that.
If players go to Energy and Electricity section, they can take out Nuclear Reactor and Nether Star Reactor from the gui. If they close the Guide, they are unable to open it anymore. (just after a restart or some glitch with '/sf search a')

Steps to reproduce the Issue (Required)

  1. Open SF Guide
  2. Go to Energy and Electricity section
  3. Find Nuclear Reactor or Nether Star Reactor
  4. You can take out them from the gui to your inventory.
  5. Close the Guide.
  6. And try to open it again.
Spoiler: Images (Click me!)

image
image

Expected behavior (Required)

In a normal situation I shouldn't be able to take out anything from the Slimefun Guide, the items must jump back into the Guide.

Server Log / Error Report

When I took out the generators: https://pastebin.com/dr4Y30WB
After I closed the guide and tried to open it again: https://pastebin.com/8D6mRejF

Environment (Required)

image

  • Minecraft Version: git-Paper-226 (MC: 1.14.4)
  • Slimefun Version: Slimefun vDEV - 350 (git 8183a1a5)
  • CS-CoreLib Version: CS-CoreLib vDEV - 78 (git 199e1b1e)
commented

@OpticFusion1 Well feel free to PR your changes. It's open source for a reason... yes a lot of the legacy code is badly done, it was done years and years ago. I've made changes to improve the code and performance as have others (Including @TheBusyBiscuit even though he stopped mainly developing it a few years ago). We all know some of the code is very bad and inefficient but it can't improve without people actually contributing. Considering actually making a PR then rather than snarky comments.

  • 👍2