Slimefun

Slimefun

3M Downloads

Android Miner Can't Dig Cobblestone.

xMikux opened this issue ยท 8 comments

commented

Description (Required)

Android Miner Can't Dig Cobblestone.

Evidence / Proof (Required)

Put android miner in front of cobblestone and set script dig forward.
And you will see cobblestone not dig.

Environment (Required)

[01:52:08 INFO]: Paper v1_14_R1
[01:52:08 INFO]:
[01:52:08 INFO]: CS-CoreLib vDEV - 79 (git ec5b4c24)
[01:52:08 INFO]: Slimefun vDEV - 367 (git aa9652c)
[01:52:08 INFO]:
[01:52:08 INFO]: Installed Addons (12)
[01:52:08 INFO]: HotbarPets vDEV - 20 (git cd87bc60)
[01:52:08 INFO]: ExtraGear vDEV - 3 (git de222ab7)
[01:52:08 INFO]: ExoticGarden vDEV - 22 (git a855f5b7)
[01:52:08 INFO]: Barrels vDEV - 7 (git 0d14dd9f)
[01:52:08 INFO]: ElectricSpawners vDEV - 5 (git c3f8cc9d)
[01:52:08 INFO]: ExtraHeads v1.1
[01:52:08 INFO]: SoulJars vDEV - 4 (git 4a600aa2)
[01:52:08 INFO]: PrivateStorage vDEV - 6 (git b012877e)
[01:52:08 INFO]: ChestTerminal vDEV - 19 (git ebf13b83)
[01:52:08 INFO]: DyedBackpacks vDEV - 1 (git 4b4d1f0f)
[01:52:08 INFO]: SlimefunOreChunks vDEV - 3 (git 7ddf966e)
[01:52:08 INFO]: SlimeXpansion vDEV - 4 (git 5bf10c29)

commented

Could you provide a video of this bug? Just tested on the latest slimefun build and the android miner appears to be working fine. Make sure your android has fuel, an empty inventory, and that you manually start the script.

commented

https://youtu.be/vbWNDBJG6u4
And this video will remove if bug fix or is not a bug.

commented

Got reported on my server aswell

'
Hi guys, so the miner android stopped mining cobble. Checked the script, seems fine, tested over and over, and yeah it could mine sand etc etc. It couldnt mine cobblestone anymore for some reason. Note: it worked yesterday it mined about 3 dubs of cobble before i noticed it stopped mining it'

commented

yeah reported to me, i retested with my own - previously worked in 1.14 script in the exact same build to verify. Miner does everything else it should: gets fuel, puts items into item interface, turns, ... just does not mine.

commented

Block.getDrops() seems to be returning what would be dropped if the block were broken by hand (no tool). For things like obsidian and cobblestone, this is nothing. I'm not sure whether that makes this a Spigot bug or not.

Maybe Slimefun could just use Block.getDrops(diamondPickaxeStack)

commented

@creator3 Interesting. I wouldnt say it is a Spigot bug, but it definitely used to be different in the past.

I would agree with your solution of just giving the method a diamond pick (used in the crafting anyway). The ItemStack should be static and final though, no need to create a new one on every call.

commented

just testest the merge on 1.14 it also fixes this issue even though walshy screams in my ear it doesnt make sense

commented

This was broken in Spigot itself, apparently "fixing" an issue despite changing how a method has worked for literally years. Any newer builds of 1.14.4 and 1.15+ will all have this change. Fucking Spigot man...

Commit ref: https://hub.spigotmc.org/stash/projects/SPIGOT/repos/craftbukkit/commits/eeae942e443a30782a12dfd69015350e1c3ea7a2