Soulbound items does not keep on death
DerangedWifi opened this issue · 9 comments
Description (Required)
Soulbound items are not keeping on death. I have tested the soulbound bag and the Elytra.
Steps to reproduce the Issue (Required)
https://medal.tv/clips/14795483/d1337zCocBRA
Clipped with Medal. Testing the bag. It is unlocked in my guide.
Expected behavior (Required)
For the bag or Elytra to keep on death.
Server Log / Error Report
No issues that could be related to this problem. Exotic plants has issues with EpicWorldGen on deciding what block is which, but thats unrelated.
Environment (Required)
https://cdn.discordapp.com/attachments/565569196218384385/662052769754120223/unknown.png
- Minecraft Version: 1.14.4
- Slimefun Version: vDev - 385
- CS-CoreLib Version: vDev - 80
affects all soulbound items, also on minecraft 1.15.1 cs-corelib version 79 as well as 80.
oops, nevermind, guess it stops working entirely on reconnect if one of the items is only affected by a "soulbound rune" and not actually a named "Soulbound..." item, so this fix appears to have very little affect.
https://youtu.be/MoTwQw82aCU
-- on reconnect without soulbound rune affected item ("Soulbound Sword" only)
sorry guess it got edited after i made my ticket, when i was copied on it, it originally had the same bot message that was posted to this one.
The bot message is always posted but it was removed by Cookie right after it was posted.
@TheBusyBiscuit we really need a way to see how it was closed... only if closed by you (with no commit) then post.
@WalshyDev I already asked GitHub's support to add a way to check that with their API.
Like a simple "closed_via_commit" attribute for issues...
So far it's not really coming any time soon...
@mrcoffee1026 Well you should rather pay attention to the checkmarks of the bot message instead...
On yours I checked that it was fixed in a newer version.
Here the message was deleted as soon as it was posted (It was deleted 15 minutes before you posted your issue btw...).
But no checkmark would have been set.
Ok, I didn't know there might even be checkmarks in this list: but it still doesn't work. Just retested with build 388: this does include your commit, correct? When I logged back in for my test user... his soulbound sword had been returned... but giving him another item and killing him again caused him to lose both items.