Slimefun

Slimefun

3M Downloads

Fluid Pump: Lava dupe!

Lehinx opened this issue ยท 1 comments

commented

Description (REQUIRED)

Buckets get filled from non-source water/lava.

#2256

Steps to reproduce the Issue (REQUIRED)

https://www.youtube.com/watch?v=quJMXYGEzb0

Expected behavior (REQUIRED)

Shouldn't fillup buckets from non-source lava/water.

Server Log

Error Reports

Environment (REQUIRED)

  • Server Software (Spigot/Paper): Paper
  • Minecraft Version: 1.16.2-R0.1-SNAPSHOT
  • Slimefun Version: DEV - 648
  • CS-CoreLib Version: DEV - 79
commented

I think this is caused by Vein.find method. The method can fill the list it returns with the same blocks so in this case the non-source blocks. Gonna fix that in a pr to cs-corelib2 soon.