Christmas Present unusable
StarWishsama opened this issue ยท 5 comments
๐ Description (REQUIRED)
Christmas Present can be placed and can't work properly.
๐ Steps to reproduce the Issue (REQUIRED)
- Take a Christmas Present and place.
๐ก Expected behavior (REQUIRED)
Get present from Christmas Present
๐ Server Log
No error log
๐ /error-reports/ Folder
No error report
๐งญ Environment (REQUIRED)
[23:22:11 INFO]: This Server uses the following setup of Slimefun:
[23:22:11 INFO]: Paper v1_16_R2
[23:22:11 INFO]: CS-CoreLib vDEV - 91 (git e42a05d1)
[23:22:11 INFO]: Slimefun vDEV - 729 (git 38bf228)
[23:22:11 INFO]: Metrics build: #17
[23:22:11 INFO]:
[23:22:11 INFO]: Installed Addons: (3)
[23:22:11 INFO]: ClayTech v1.2.17
[23:22:11 INFO]: Residence v4.9.1.9
[23:22:11 INFO]: ExoticGarden vDEV - 55 (git cce4c0f4)
It is not christmas.
So it only available on christmas? I tried easter egg and it works
Christmas Present
public class ChristmasPresent extends SimpleSlimefunItem<BlockPlaceHandler> implements NotPlaceable
it implements NotPlaceable but it need be placed to get present. (See BlockListener)
if i'm wrong please correct me
The NotPlaceable interface clearly doesn't cancel any block place events as stated in its javadoc. It just simply prevents SF from registering this as a placed block (in BlockStorage) https://github.com/Slimefun/Slimefun4/blob/master/src/main/java/io/github/thebusybiscuit/slimefun4/core/attributes/NotPlaceable.java#L8-L18
The NotPlaceable interface clearly doesn't cancel any block place events as stated in its javadoc. It just simply prevents SF from registering this as a placed block (in BlockStorage) https://github.com/Slimefun/Slimefun4/blob/master/src/main/java/io/github/thebusybiscuit/slimefun4/core/attributes/NotPlaceable.java#L8-L18
isn't it affect the present? I only saw call BlockPlaceHandler in here, and present did used BlockPlaceHandler while Listener won't call block place when it's NotPlaceable.
But it isn't related to NotPlaceable indeed.