Book GUIs broken on latest build of CraftBukkit/Spiot/Paper
mav2020 opened this issue ยท 6 comments
๐ Description (REQUIRED)
Elevator plates do not work and throw an error in the console "Could not pass event PlayerInteractEvent to Slimefun vDEV - 771 (git f2dd3a0)". This started after I updated Paper. It works fine in Paper Build 328 (and probably newer than that), but I have tried several of the "newer builds" and they do not work.
๐ Steps to reproduce the Issue (REQUIRED)
- Update to a newer version of Paper
- Step on a Slimefun Elevator plate
๐ก Expected behavior (REQUIRED)
Expect to be given option to go to another elevator level.
๐ Server Log
๐ /error-reports/ Folder
No error reports in Slimefun folder
๐งญ Environment (REQUIRED)
- Server Software: Paper 1.16.4 Build 366
- Minecraft Version: 1.16.4
- Slimefun Version: 771
- CS-CoreLib Version: 91
-
sf versions
[07:52:17 INFO]: This Server uses the following setup of Slimefun:
[07:52:17 INFO]: Paper v1_16_R3
[07:52:17 INFO]: CS-CoreLib vDEV - 91 (git e42a05d1)
[07:52:17 INFO]: Slimefun vDEV - 771 (git f2dd3a0)
[07:52:17 INFO]: Metrics build: #6
[07:52:17 INFO]:
[07:52:17 INFO]: Installed Addons: (0)
After some testing, I found that the issue started with Paper Build 356. It seems to work fine in build 355 and below.
I looked into Paper's commit history.
The issue itself was caused by a recent commit inside CraftBukkit, Spigot and Paper simply inherited that.
The latest commit to CraftBukkit basically broke all compatibility for book interfaces, so that's fun...
It is gonna be a long and painful thing to fix and would need to be fixed in CS-CoreLib2, not in Slimefun. But I am gonna leave this issue open on this repository, so that others don't get tempted to make duplicates.
So for anyone who wants to look into it... This is the commit that broke everything:
https://hub.spigotmc.org/stash/projects/SPIGOT/repos/craftbukkit/commits/560b65c4f8a15619aaa4a1737c7040f21e725cce#src/main/java/org/bukkit/craftbukkit/inventory/CraftMetaBook.java
Thanks for giving the exact Paper version this started to break btw, it made tracking it down a lot easier.
This has been fixed in CraftBukkit, user has confirmed broken items are also fixed. Let us know if you still have this issue.
Paper version 393 with the latest SF version and CS-CoreLib is still giving the exact same error. (no other plugins installed)
sf versions
[19:36:53 INFO]: This Server uses the following setup of Slimefun:
[19:36:53 INFO]: Paper v1_16_R3
[19:36:53 INFO]: CS-CoreLib vDEV - 92 (git e9150d72)
[19:36:53 INFO]: Slimefun vDEV - 774 (git e66af68)
[19:36:53 INFO]: Metrics build: #6
[19:36:53 INFO]:
[19:36:53 INFO]: Installed Addons: (0)