Slimefun

Slimefun

3M Downloads

Crafting items while the Server is restarting

variananora opened this issue ยท 5 comments

commented

๐Ÿ“ Description (REQUIRED)

Item in Auto Enchanter or Auto Disenchanter will disappear after a server reboot.

https://youtu.be/CoIFcN7B7f8

๐Ÿ“‘ Steps to reproduce the Issue (REQUIRED)

  1. Use Auto Disenchanter or Auto Enchanter
  2. Reboot the server
  3. Item is gone

๐Ÿ’ก Expected behavior (REQUIRED)

The item inside Auto Enchanter or Auto Disenchanter should not be missing

๐Ÿ“œ Server Log

https://pastebin.com/xV7gUAn2

๐Ÿ“‚ /error-reports/ Folder

There is no error log.

๐Ÿงญ Environment (REQUIRED)

  • Server Software: git-Paper-403
  • Minecraft Version: 1.16.4
  • Slimefun Version: DEV-780
  • CS-CoreLib Version: DEV-79
    (Optional, idk why i'm including this, just incase.)
  • BentoBox Version: 1.15.3
    • Caveblock Addons: 1.14.2
      image
commented

A possible solution could be:
On shutdown -> save machine operation to blockstorage
On startup -> check blockstorage for machine operation -> if found load the machine operation and continue

commented

That's not really a bug, it's just the way the system works and it always did so.
This is probably not going to be "fixed" or more like "added" within the next year or two.
But I guess I will leave it open incase someone else sees it, perhaps we can make it a Hacktoberfest issue in october XD

commented

Keep in mind, the actual item, if it finishes 'cooking' does remain in the machine through a reboot.
It's only items that are in the process of being completed, that vanish.

commented

Several years ago it used to dupe the item being enchanted/disenchanted, it was changed to this behavior back then to fix the dupe.

commented

If the auto enchanter doesn't take the items at the beginning of the enhancement, but when the enchant just finished, the items won't be lost.
That is, when the server restart, the items remain in the container. What we lost is just "enchant progress", but not the equipments.
I think it could be a safe solution.