mcMMO AbilityBuff bug
Rothes opened this issue · 4 comments
📍 Description (REQUIRED)
When cargo transports a item, Slimefun doesn't check if the item has a AbilityBuff.
For example. We can keep the dig_speed enchantment from Super Breaker Skill like this:
📑 Steps to reproduce the Issue (REQUIRED)
- Activate Super Breaker Skill with a pickaxe
- Put the pickaxe in a item frame
- Wait for the skill to end
- Remove the pickaxe from the frame. Let it goes into a hopper.
- Transport the pickaxe into a Auto-Disenchanter by cargo.
- The dig_speed buff enchantment doesn't remove. Then just disenchant it to hold the enchantment.
- put the pickaxe and the enchanted_book in Auto-Enchanter.
- Repeat the operation. You can get unlimited enchantment level.
💡 Expected behavior (REQUIRED)
run SkillUtils#removeAbilityBuff when transporting a item,
or handlering something in machine.
📜 Server Log
None
📂 /error-reports/ Folder
None
🧭 Environment (REQUIRED)
Tuinity git-Tuinity-"1b0d783" (MC: 1.16.5)
Slimefun DEV - 853 (git f4bded9)
Metrics-Module #21
Java 11
Installed Addons: (3)
SlimefunItemId v1.0
Residence v4.9.3.3
CMI v8.8.2.2
[mcMMO] Running version 2.1.184
I think I will resolve this from mcMMO's point of view in this case.
mcMMO sanitizes tools when dropped, clicked or even when opening inventories.
It not doing that when using Item Frames seems like an oversight that needs to be patched.
I think I will resolve this from mcMMO's point of view in this case.
mcMMO sanitizes tools when dropped, clicked or even when opening inventories.
It not doing that when using Item Frames seems like an oversight that needs to be patched.
Note that Infused Hopper or maybe other things can replace of the Item Frames.
There are many ways to get the pickaxe with the enchantment.
So I still think it should be fixed from us... maybe
Yo. This patch fixes a part of it.
We need to prevent Slimefun items get the enchantment too.