Slimefun

Slimefun

Bukkit Plugins
3M Downloads

Disenchanter disappears after max level cap

bobhenl opened this issue · 8 comments

commented

📍 Description (REQUIRED)

Hi, I want to report that when you put some Slimefun item with a higher enchantment that you set in your items.yml, for ex. I set 5:

  use-enchant-level-limit: true
  enchant-level-limit: 5

then a disenchanter & item disappear

📑 Steps to reproduce the Issue (REQUIRED)

  1. Set enchant level limit to 5 and set true in use enchant level limit.
  2. Put item with higher enchantment than 5 into the disenchanter
  3. Now item & disenchanter disappear

💡 Expected behavior (REQUIRED)

It probably should rather say that it's not possible to disenchant this item or something like this.

📜 Server Log

[18:36:58] [Server thread/WARN]: [Slimefun] 
[18:36:58] [Server thread/WARN]: [Slimefun] An Error occurred! It has been saved as: 
[18:36:58] [Server thread/WARN]: [Slimefun] /plugins/Slimefun/error-reports/2021-04-04-18-36.err
[18:36:58] [Server thread/WARN]: [Slimefun] Please put this file on https://pastebin.com/ and report this to the developer(s).
[18:36:58] [Server thread/WARN]: [Slimefun] Bug Tracker: https://github.com/Slimefun/Slimefun4/issues
[18:36:58] [Server thread/WARN]: [Slimefun] 
[18:36:59] [Server thread/INFO]: _Fun0s_ issued server command: /back
[18:37:00] [Craft Scheduler Thread - 3779 - Slimefun/ERROR]: [Slimefun] X: -4,855 Y: 78 Z: -2,310 (AUTO_DISENCHANTER)
[18:37:00] [Craft Scheduler Thread - 3779 - Slimefun/ERROR]: [Slimefun] has thrown 4 error messages in the last 4 Ticks, the Block has been terminated.
[18:37:00] [Craft Scheduler Thread - 3779 - Slimefun/ERROR]: [Slimefun] Check your /plugins/Slimefun/error-reports/ folder for details.
[18:37:00] [Craft Scheduler Thread - 3779 - Slimefun/ERROR]: [Slimefun]  
[18:37:00] [Craft Scheduler Thread - 3779 - Slimefun/ERROR]: [Slimefun] An Exception was caught while ticking the Block Tickers Task for Slimefun vDEV - 869 (git 18139bb5)
java.util.ConcurrentModificationException: null
	at java.util.HashMap$HashIterator.nextNode(HashMap.java:1445) ~[?:1.8.0_281]
	at java.util.HashMap$KeyIterator.next(HashMap.java:1469) ~[?:1.8.0_281]
	at io.github.thebusybiscuit.slimefun4.implementation.tasks.TickerTask.tickChunk(TickerTask.java:144) ~[?:?]
	at io.github.thebusybiscuit.slimefun4.implementation.tasks.TickerTask.run(TickerTask.java:114) ~[?:?]
	at org.bukkit.craftbukkit.v1_16_R3.scheduler.CraftTask.run(CraftTask.java:100) ~[patched_1.16.5.jar:git-Purpur-1048]
	at org.bukkit.craftbukkit.v1_16_R3.scheduler.CraftAsyncTask.run(CraftAsyncTask.java:58) ~[patched_1.16.5.jar:git-Purpur-1048]
	at com.destroystokyo.paper.ServerSchedulerReportingWrapper.run(ServerSchedulerReportingWrapper.java:22) ~[patched_1.16.5.jar:git-Purpur-1048]
	at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149) [?:1.8.0_281]
	at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624) [?:1.8.0_281]
	at java.lang.Thread.run(Thread.java:748) [?:1.8.0_281]

📂 /error-reports/ Folder

https://pastebin.com/7LgBjJSz
https://pastebin.com/yywyLMuh
Two with auto & advanced disenchanters. BTW one is from InfinityExpansion IK.

🧭 Environment (REQUIRED)

  • Server Software: Purpur
  • Minecraft Version: 1.16.5
  • Slimefun Version: 869
commented

wtf why it was closed... I put there error logs too. So why it got closed?

commented

I also tested this with the latest paper and latest purpur couldnt reproduce the error i tried with reinforced helmet. and with the yml settings shown above

Latest purpur 1051
Latest paper 582

commented

Can't reproduce this on Paper/Purpur

2021-04-06.14-42-55.mp4

image

Testing with addons:
2021-04-06.14-40-09.mp4
Items.yml

image
image
image

commented

Oh I've discovered it's due to missing lang string probably. It happened for me when I had language: cs

commented

Oh I've discovered it's due to missing lang string probably. It happened for me when I had language: cs

Well that is interesting. I'll check it later.

commented

Mhm?

commented

because the new 1 got closed

this is actually a valid bug when the language file has been changes for example use cs as language and it will remove the block
I have tested this and it does remove the machine
console error
pastebin.com/LDpQajnL
error report
pastebin.com/rCgKcQNH
image

commented

Change title to: Machine will broke it self if you are using corrupted/not complete lang files and not fallback to EN lang files like Walshy said in #2952.

Tested with CS language and remove some portion of the machine like Panda did.