Slimefun

Slimefun

3M Downloads

Auto-Enchanter has strict slot order

100petr opened this issue ยท 4 comments

commented

๐Ÿ“ Description (REQUIRED)

The author enchanter does not work if the item is on the left (first) slot

๐Ÿ“‘ Steps to reproduce the Issue (REQUIRED)

  1. Place auto enchanter
  2. Insert an item (such as a pickaxe) into the left (first) slot
  3. Insert an enchanted book (eg unbreaking) into the right (second) slot
  4. Nothing happens
    If the enchanted book is placed in the left (first) slot and the item in the right (second), the auto enchanter works.
    Video: https://youtu.be/NPX6k2nsg-Q

๐Ÿ’ก Expected behavior (REQUIRED)

The auto enchanter will work if there is an item in the right (first) slot and an enchanted book in the left (second) slot

๐Ÿ“œ Server Log

N/A

๐Ÿ“‚ /error-reports/ Folder

N/A

๐Ÿงญ Environment (REQUIRED)

image

commented

I was able to confirm and replicate the issue

commented

I'm able to replicate the issue on my server as well.
image

commented

Confirmed.

image

commented

Can confirm that it is caused by commit cb3e9d. What happens: because isEnchantable now returns false instead of true under specific conditions, the for loop only loops once and returns null instead of checking both combinations of book and item.