Slimefun

Slimefun

3M Downloads

Missing localization on Pickaxe of The Seeker error message.

variananora opened this issue · 3 comments

commented

❗ Checklist

  • I am using the official english version of Slimefun and did not modify the jar.
  • I am using an up to date "DEV" (not "RC") version of Slimefun.
  • I am aware that issues related to Slimefun addons need to be reported on their bug trackers and not here.
  • I searched for similar open issues and could not find an existing bug report on this.

📍 Description

When Pickaxe of The Seeker didn't find any ores it will just return null rather than the error message.

I think this is the underlying issue. (I'm probably wrong)

SlimefunPlugin.getLocalization().sendMessage(p, "miner.no-ores");

This pointed to miner.no-ores and it doesn't exist on https://github.com/Slimefun/Slimefun4/blob/master/src/main/resources/languages/en/messages.yml

📑 Reproduction Steps

  1. Get Pickaxe of The Seeker
  2. Get away from ores
  3. Right click
  4. Get null messages

💡 Expected Behavior

It should just return the localization on error message.

📷 Screenshots / Videos

2021-05-06.08-44-43.mp4

📜 Server Log

No response

📂 /error-reports/ folder

No response

💻 Server Software

Paper

🎮 Minecraft Version

1.16.x

⭐ Slimefun version

image

🧭 Other plugins

No response

commented

So.... I was thinking to make a PR on this one right, idk if I should just update the messages.yml or I need to do other things too?

commented

Just the appropriate English file. Nothing else

commented

Also perhaps change the locale path, "minor.no-ores" seems a bit off, probably was part of the old Digital Miner