❗ Checklist

• I am using the official english version of Slimefun and did not modify the jar.
• I am using an up to date "DEV" (not "RC") version of Slimefun.
• I am aware that issues related to Slimefun addons need to be reported on their bug trackers and not here.
• I searched for similar open issues and could not find an existing bug report on this.

📍 Description

Slimefun cargo adds texture to the renamed item

📑 Reproduction Steps

I have in the ItemsAdder item named Coin with a texture on the stick.
I'll put the coin in the first chest
I'll put a stick renamed to Coin in the second chest
I'll have the stick renamed Coin transferred via cargo
The stick acquires the texture of the coin
(Coin (ENG) = Mince (CZ))

We tried it with other items and it works like this with everything.

💡 Expected Behavior

The item transferred through the cargo does not acquire texture

📷 Screenshots / Videos

The videos were more than 10MB and could not be uploaded, I give a link to youtube
https://youtu.be/I1baDR_b1YQ
https://youtu.be/1-mUxS-7ADA

📜 Server Log

N/A

📂 /error-reports/ folder

N/A

💻 Server Software

Purpur

🎮 Minecraft Version

1.16.x

⭐ Slimefun version

🧭 Other plugins

This is surely something that is not related to ItemsAdder directly.
I'm not handling the stacking of items in any way.
Probably Slimefun has an item matcher function which doesn't check also for CustomModelData but only for lore and display name, this is the cause of the wrongly merged items

That would still be for the BlockPlacer though. In this case, the player is trying to place by hand (and the underlying item is an iron ingot so there should be no BlockPlaceEvent being called, just PlayerInteractEvents)

Yea i got it wrong

I’m happy to test this later today and try to work out what is actually firing when this is attempted?

I may have found the issue, will give a follow up comment about it

Ah good, i've just seen its like £15 so i likely wouldn't have likely gotten anywhere xD

This is alongside name checks and other things. Are those enough to make sure it's unique? If not, do you have a suggestion?

Thanks for the update, but I think custommodeldata check is not enough.
Some items might have the same custommodeldata but may be different custom items.

This statement is valid not only for itemsadder, but surely other plugins or datapacks would have this issue.

I feel like if the "material, name, lore and customModelData" are all identical, it should be identical in 99.9999999999% of cases.
If not, we can always add another comparison layer or just a direct integration when a new issue about it pops up.

For now you can rely on the CustomModelData + DisplayName and Lore, I think it's enough for now.

Hello, I'm the developer of ItemsAdder, if any of Slimefun devs need a license for ItemsAdder I can provide it for free, just send me your Spigot username here