BlockLocker bug
JustinDevB opened this issue · 7 comments
❗ Checklist
- I am using the official english version of Slimefun and did not modify the jar.
- I am using an up to date "DEV" (not "RC") version of Slimefun.
- I am aware that issues related to Slimefun addons need to be reported on their bug trackers and not here.
- I searched for similar open issues and could not find an existing bug report on this.
📍 Description
Breaking a BlockLocker sign that was placed from the offhand while holding a slimefun item causes the slimefun item to be duped.
📑 Reproduction Steps
- Have BlockLocker installed
- Put a sign into offhand
- Place sign onto the side of a block (Any block will do)
- Hold the slimefun item you want to duplicate in your main hand
- Break the sign. Instead of the sign dropping, a duplicated slimefun item drops.
This only works with slimefun items
💡 Expected Behavior
slimefun items should not be duplicated in this manner.
📷 Screenshots / Videos
No response
📜 Server Log
No response
📂 /error-reports/
folder
No response
💻 Server Software
Purpur
🎮 Minecraft Version
1.17.x
⭐ Slimefun version
I know this isn't the latest version of slimefun, but I went through the changelogs for the versions I do not have and none of them address this issue. And given that it requires BlockLocker I am willing to bet it will work on the latest version regardless.
🧭 Other plugins
No response
I am aware I checked the up to date box even though I am not running the latest version. This bug will more than likely work on the latest build since no changelogs have addressed it.
This sounds like BlockPlaceEvent interference.
Which Slimefun items have you tried this with? The item is "placed" when it shouldn't be so when you break the sign Minecraft thinks the item is there and drops that (Minecraft is weird with block placements - for example, stripping a log "places" the axe on the log...), but we implement a NotPlaceable interface and handle with that so no item should ever get placed to begin with.
I definitely agree this should be happening with latest, tests can confirm that but eh.
I also see that BlockLocker is open source so that is handy, it seems there is no Discord though and that all bug reports are handled through GitHub/Spigot. I will see if I can get a hold of the dev to maybe help us figure out where to find possible conflicts.
Haven't found a pattern of what can be duped and what can't. Some testing has shown that Addons can be duped. Here is a video I uploaded showing how to do the dupe.
Tested this and can confirm
The item is "placed" when it shouldn't be
It seems like it. When placing a AContainer machine it will place down the machine to the BlockStorage and you still keep the item, when destroying the sign it will drop the duplicated item because Slimefun thinks that it is a BlockStorage.
EDIT: Video for clarification. https://youtu.be/2y2kkwvXuFs
Haven't found a pattern of what can be duped and what can't.
I just tried and it seems like everything that doesn't extend to NotPlaceable
? (Need to test that more later) Even a sword works...
I just went through a few more items and still looks like possibly everything can be duped.
If you use a GPS Teleporter pylon the sign disappears and the pylon gets placed next to the block
It has been 10 days since I've opened an issue report on their GitHub and it's not even been acknowledged. Unfortunately I am gonna have to close this issue, and if they ever reply we can always reopen it.
Your issue has been closed by an admin, it may fall under one or more of the following categories.
Please wait for an admin to tick off the points that apply.
- You did not follow our template. Please follow the Issue template to help us identify your issue more effectively.
- You did not provide any information about your versions (We absolutely need the exact version numbers that are installed on your Server, "latest" is not helpful)
- You did not provide a proper description to the problem. Try to write at least 4-6 sentences and/or provide screenshots or videos on how to reproduce this.
- We were unable to reproduce issue, if you think your issue still persists then please comment down below and give a better description on how to reproduce it.
- Your issue was posted in a foreign language, we only accept english issues on here.
- Your issue is not a bug, it is intended to work this way.
- Your issue is not really a bug, it is a limitation or simply something we have no control over.
- Your issue is not a bug, please only use this issue tracker to report bugs. Any other kind of communication should happen on discord.
- Your issue has already been reported before, it is a duplicate. Check the other issues first before posting!
- You posted an error without using pastebin. Please always post errors via pastebin otherwise they become nearly unreadable.
- You seem to be reporting multiple bugs at once. Please make a separate issue for each bug you encountered, so we can properly handle them individually.
- Your issue has already been fixed in a later version of Slimefun, you should update.
- You are using an outdated and unsupported version of Slimefun, again, you should update.
- You are using an unofficially modified build of Slimefun. We only support official versions of Slimefun - for obvious reasons.
- You are using an unsupported version of Minecraft. We only provide support for the Minecraft versions Slimefun was developed for, older versions are not supported anymore.
- You are using a "stable" version of Slimefun (prefixed with "RC - "), your issue may have been fixed in a development build, so we only accept bug reports from those.
- You are on the wrong issue tracker. We would like to remind you that this Issue Tracker is only for Slimefun. To report bugs on any addons, head to the corresponding issue tracker of that addon.
Please respond below, if you have any further questions.
Do not open a new Issue unless explicitly told otherwise, comment below or edit your post instead.
Make sure to check out our article on How to report bugs for even more information.