Disabling some Slimefun items shifted some multiblocks recipe
variananora opened this issue · 8 comments
❗ Checklist
- I am using the official english version of Slimefun and did not modify the jar.
- I am using an up to date "DEV" (not "RC") version of Slimefun.
- I am aware that issues related to Slimefun addons need to be reported on their bug trackers and not here.
- I searched for similar open issues and could not find an existing bug report on this.
📍 Description
In this case I'll disable Stone Chunks from items.yml and try using Compressor
This also happened here: Slimefun-Addon-Community/ExoticGarden#210
I think this is because when registering recipe it didn't check for the disabled items.
I haven't tried anything else but looking at things I think I can make this work one Ore Grinder and Ore Crusher too..
📑 Reproduction Steps
- Install Slimefun
- Disable Stone Chunks from
items.yml - Look at the guide, the recipe just got shifted
- Try using the compressor just using 1 coal
- It will output 8 coal
💡 Expected Behavior
The recipe should not be shifted.
📷 Screenshots / Videos
Side by side
Normal Recipe
Shifted Recipe
📜 Server Log
No response
📂 /error-reports/ folder
No response
💻 Server Software
Paper
🎮 Minecraft Version
1.17.x
⭐ Slimefun version
> sf versions
[10:34:39 INFO]: This Server uses the following setup of Slimefun:
Paper git-Paper-279 (MC: 1.17.1)
Slimefun DEV - 974 (git 36c6d154)
Metrics-Module #28
Java 16
No Addons installed
🧭 Other plugins
No response
Is this still an issue?
yes it is.
Do you know if it only happens with multiblocks or if it also happens with things like machines and the ancient altar
just tested it and it only in multiblocks machine
it is not happening in ancient altar nor on machines.
Update: i think this is why it happens
This code checks for the item is disabled or not and added it to the recipe, thus making it shifted by 1 item.
This make sures the item is not able to be crafted or used as a crafting recipe.
Machines doesnt have this issue since it never check the item is disabled or not.
But because it never checks the item is disabled or not, it still works inside the machine if you still have the items.
(Not sure it will fit inside this issue or should be seperated to another issue.)
nor do ancient altar
Alright sorry for the delay but think I made a fix for this, @variananora any chance you could test a jar? I'm not home so I can't test it and I won't be home for a couple days
@variananora any chance you could test a jar?
yeah sure just ping me at discord for this things
@variananora any chance you could test a jar?
yeah sure just ping me at discord for this things
Got it 👍