Missing Research
Solverbolt opened this issue · 3 comments
❗ Checklist
- I am using the official english version of Slimefun and did not modify the jar.
- I am using an up to date "DEV" (not "RC") version of Slimefun.
- I am aware that issues related to Slimefun addons need to be reported on their bug trackers and not here.
- I searched for similar open issues and could not find an existing bug report on this.
📍 Description
Only able to research 173 out of 174 of the total research. One is missing and not showing up.
📑 Reproduction Steps
- Grind hundreds of levels of experience
- Start Learning every research Tree
- When performing /sf stats check after learning every tree, finding that one research block is not showing up in the book, but does for the stats log.
💡 Expected Behavior
Being able to see all research would be the expected behaivor
📷 Screenshots / Videos
📜 Server Log
No response
📂 /error-reports/ folder
No response
💻 Server Software
Spigot
🎮 Minecraft Version
1.17.x
⭐ Slimefun version
Minecraft 1.17.1-R0.1-SNAPSHOT
Slimefun: Dev - 985 (git 1f3d0f5)
🧭 Other plugins
Economy
MCMMO
Tech and Magic
Quests and NPC
Custom Enchant
Many Achievements
Crates
Player Shops
Claim System (golden shovel)
I will look into that. I will get back to you once I have more information. I am only a moderator, so will have to run this up the chain. But thank you for you response.
Could you check you items.yml and ctrl+F for any enabled: false items? If you disable all the items related to one research you are never going to be able to... Well research it, and as of now the stats are based on unlocked researches over total existing researches.
Just yesterday this came up in Discord here https://discordapp.com/channels/565557184348422174/569249847258120222/918455136760758302, the viabiliy of moving stats to unlocked items over total enabled items is still under discussion as you can see in the chat
Found the issue of this. This happened because some Slimefun research are actually just a normal vanilla Minecraft items. Below listed all the affected items. The number beside it indicates what are the research id is.
I think this is an oversight in the research code, since you can't use the item that haven't been researched, that is why this vanilla items just being bypassed. (Idk why elytra works tho? probably because it have other items?)
- 74 Chainmail Armors
- 111 Armored Jetpack (the item doesnt even exist) #1315
- 249 Totem of Undying
- 279 Trident
Edit: I think I know what is the problem here.
Since these are checking for
SlimefunItems and being provided with VanillaItems it doesn't register the item in the guide but still register it as a research with 0 items. This is why the research is can't be researched since there is no item in the guide that will allows you to do so.
