Animal Growth Accelerator sometimes turning into a regular hay bale when breaking
marvjosh1 opened this issue · 12 comments
❗ Checklist
- I am using the official english version of Slimefun and did not modify the jar.
- I am using an up to date "DEV" (not "RC") version of Slimefun.
- I am aware that issues related to Slimefun addons need to be reported on their bug trackers and not here.
- I searched for similar open issues and could not find an existing bug report on this.
📍 Description
When placing down the Animal Growth Accelerator and then breaking it, it sometimes turns into a regular hay bale
(does also not throw any errors in console)
📑 Reproduction Steps
- Place the Animal Growth Accelerator
- Break it
Repeat as this only occasionally happens
💡 Expected Behavior
The Animal Growth Accelerator to be returned as the machine
📷 Screenshots / Videos
https://youtu.be/I3ovQpz5Cmo
https://youtu.be/ZEVpHCGHq9A
📜 Server Log
No response
📂 /error-reports/ folder
No response
💻 Server Software
Purpur
🎮 Minecraft Version
1.17.x
⭐ Slimefun version
https://i.imgur.com/XPPsX4B.png
https://i.imgur.com/b4ZWRqo.png
🧭 Other plugins
No response
Was able to reproduce with just Slimefun installed:
https://screenshots.skizzles.me/wAnA3/Kofimixi49.mp4
Simply by placing and removing blocks quickly causes the item to break.
Variananora, I gave it a second run and with some consistency I was able to reproduce it as well. the debug fish doesn't recognize it and the paper dumpitem command showed no nbt data. It truly is a haybale. This time I was on dev 994 in 1.18.1.
I feel like making a debug thing for you guys. Something that dumps all the events being fired and which are being handled by Slimefun. Then it can also dump a bunch of other info out.
Could use the existing debug function for that (just need to make sure regular people don't run it... it'll make a huge fucking log)
Simply by placing and removing blocks quickly causes the item to break.
The easiest way to do this is just to hold right click when you are breaking the blocks.
I seems to been able to repro this with other blocks as well, the one I tested and works are:
- Animal Growth Accelerator
- Rainbow Wool
- Wither-Proof Glass
- Refinery
- Electric Furnace III (This one is harder to repro tho, I managed to do it twice and never able to do it when I'm recording....)
Video: https://youtu.be/osxTZkMTI2M
/sf versions
> sf versions
[09:40:00 INFO]: This Server uses the following setup of Slimefun:
Paper git-Paper-133 (MC: 1.18.1)
Slimefun DEV - 992 (git 0538e345)
Metrics-Module #28
Java 17
No Addons installed
> pl
[09:40:01 INFO]: Plugins (1): Slimefun
> ver
[09:40:07 INFO]: Checking version, please wait...
[09:40:07 INFO]: This server is running Paper version git-Paper-133 (MC: 1.18.1) (Implementing API version 1.18.1-R0.1-SNAPSHOT) (Git: 5e30e19)
You are running the latest version
Previous version: git-Paper-121 (MC: 1.18.1)
No error in the console or anything - but as you can see it kinda happens sometimes from the youtube videos
were there any errors in the console or the slimefun folder? I've tried over 100 times mining one and it never dropped as anything but the animal growth accelerator. I tested with every official addon on my server and couldn't reproduce this
I just tried it again letting the accelerator sit for varying amounts of time, from mining right away to sitting for 30 seconds, next to, away from and different lengths from the power regulator and cannot produce this. Now I've only tested it with all slimefun plugins on the server, no essentials, cmi, or any of the custom slimefun plugins void realms has. So far it would appear another plugin may be interfering with it. If you have a test server where you can load up the official slimefun plugins, then one at a time add the others until the culprit is found?
I can't seems to replicate this. If you have something feel free to reply on this or tag me on Discord.
I've been testing this and other blocks, and I believe I may have figured out why. While in the real world no one really places and item and mines it up right away, I think this is what's happening.
Minecraft ticks faster than slimefun, so follow this logic
as you mine the accelerator with your left hand, and are holding down right click to place another, once the placed one is mined, the next mc tick the one in your right hand is placed. at the same time, the next sf tick, slimefun goes to delete the stored data of that accelerator. Because a new one is already placed, sf deletes the data of that new block you just placed, and it reverts to a vanilla block. slimefun doesn't go to update the stored data to become the new accelerator, because the block you just placed becomes a vanilla hay bale as a result of deleting the data on the new block, and therefore it's no longer a slimefun item.
Can be fixed in the blockstorage rewrite, had this problem on block breaker, and even tested it on android miner, fast place and break will turn the sf block to Normal vanilla, that's why I ditched sf block breaking for electric block breaker and opt to vanilla only for the meantime. Blockstorage checks is not synchronized with mc ticks iirc