Slimefun

Slimefun

3M Downloads

Feature request - Call entity damage event when storm staff causes lightning damage

ChanceSD opened this issue · 4 comments

commented

❗ Checklist

  • I am using the official english version of Slimefun and did not modify the jar.
  • I am using an up to date "DEV" (not "RC") version of Slimefun.
  • I am aware that issues related to Slimefun addons need to be reported on their bug trackers and not here.
  • I searched for similar open issues and could not find an existing bug report on this.

📍 Description

As requested by @Sfiguz7
Basically to have some way for other plugins to identify that lightning from storm staff came from a player so it can be blocked as PvP. Suggestions were metadata or calling the damage event.

📑 Reproduction Steps

N/a

💡 Expected Behavior

N/a

📷 Screenshots / Videos

No response

📜 Server Log

No response

📂 /error-reports/ folder

No response

💻 Server Software

Spigot

🎮 Minecraft Version

1.18.x

⭐ Slimefun version

N/a

🧭 Other plugins

No response

commented

I do but we don't really have a place except here. I don't think this should be made a suggestion, it is not exactly an addition just a compatibility fix that would make Slimefun's accessibility better overall, and I still wanted to have it written somewhere to reference when PRing

commented

@Sfiguz7 You very well know feature requests do not belong on the bug tracker...

commented

A little off topic but I think this could 'fix' #3396
EDIT: What I meant is like to be able to use storm staff and just let it work as long as no one is hurt. Or enable it to mobs and not to people.

commented

Closing this issue as it's not really a bug report and its already served its purpose of reminding @Sfiguz7 to make a PR.
The discussion can continue in #3411 if there is a need for further discussion in the first place.