Incompatibility with IAxPresenceFootsteps
Garfieldwxg55 opened this issue · 9 comments
❗ Checklist
- I am using the official english version of Slimefun and did not modify the jar.
- I am using an up to date "DEV" (not "RC") version of Slimefun.
- I am aware that issues related to Slimefun addons need to be reported on their bug trackers and not here.
- I searched for similar open issues and could not find an existing bug report on this.
📍 Description
Hi, I was recently creating an SMP server, and I tried installing ItemsAdder, Slimefun, and an ItemsAdder addon called IAxPresenceFootsteps, which adds compatibility for the mod Presence Footsteps to ItemsAdder.
https://github.com/Andre601/IAxPresenceFootsteps
However, when I tested the mod, I noticed that when Slimefun was installed, it caused IAxPresenceFootsteps to load before ItemsAdder instead of after, and since ItemsAdder is a dependency of IAxPresenceFootsteps, the plugin doesn't work.
📑 Reproduction Steps
- Download the latest versions of Slimefun, ItemsAdder, and IAxPresenceFootsteps to a server.
- Start the server
- Notice that IAxPresenceFootsteps loads before ItemsAdder instead of after like it should?
💡 Expected Behavior
I expected IAxPresenceFootsteps to load after ItemsAdder like it normally does instead of before as it did here.
📷 Screenshots / Videos
No response
📜 Server Log
📂 /error-reports/
folder
No response
💻 Server Software
Paper
🎮 Minecraft Version
1.18.x
⭐ Slimefun version
Slimefun version DEV - 1014 (git f431aa6)
🧭 Other plugins
ItemsAdder, IAxPresenceFootsteps
Heyo. Dev of IAxPresenceFootsteps here to give some extra info real quick.
Before you claim it's an issue on my end: No. My plugin has ItemsAdder
defined as Softdepend in its plugin.yml (I dislike using depend because of ugly stacktraces) and I also run a basic "if ItemsAdder not enabled" check to disable the plugin in the onEnable (not onLoad) part.
Relevant lines:
https://github.com/Andre601/IAxPresenceFootsteps/blob/45db1168e745337f57412ebd8b6f50c8ddba02eb/src/main/resources/plugin.yml#L8-L9
I have discussed this with the user in Discord and after trial and error did we figure out that Slimefun for whatever reason is messing up the plugin load and enable behaviour, which certainly isn't good.
Either way, just wanted to leave this here to make clear that I'm not manipulating the Spigot Server on runtime or whatever...
The plugin is pretty much a bare-bones one when it comes down to using the Spigot API.
It seems that this is an issue caused by the server itself.
Tho, given that testing with just Slimefun, ItemsAdder and IAxPresenceFootsteps yields the same results makes me assume there is an issue in SlimeFun's end.
Either way, the issue I talk about is this one: PaperMC/Paper#5992
It may be that Iris and Viaversion is missing here, but I'm not certain if this is ItemsAdder:
[16:26:03] [Server thread/ERROR]: Could not load 'plugins\itemsadder-blocks-injector_0.0.4.jar' in folder 'plugins'
org.bukkit.plugin.UnknownDependencyException: Unknown/missing dependency plugins: [Iris, ViaVersion]. Please download and install these plugins to run 'ItemsAdderBlocksInjector'.
at org.bukkit.plugin.SimplePluginManager.loadPlugins(SimplePluginManager.java:291) ~[paper-api-1.18.2-R0.1-SNAPSHOT.jar:?]
at org.bukkit.craftbukkit.v1_18_R2.CraftServer.loadPlugins(CraftServer.java:418) ~[paper-1.18.2.jar:git-Paper-367]
at net.minecraft.server.dedicated.DedicatedServer.initServer(DedicatedServer.java:288) ~[paper-1.18.2.jar:git-Paper-367]
at net.minecraft.server.MinecraftServer.runServer(MinecraftServer.java:1163) ~[paper-1.18.2.jar:git-Paper-367]
at net.minecraft.server.MinecraftServer.lambda$spin$0(MinecraftServer.java:315) ~[paper-1.18.2.jar:git-Paper-367]
at java.lang.Thread.run(Thread.java:833) ~[?:?]
Is this still a problem? As the relevant issue has since been fixed (as of a week ago)
@Andre601 @FivesBlue Can anyone confirm that this is still an issue otherwise this'll be closed 👍
I think this is a more general issue with circular dependencies in Spigot, so not a Slimefun issue I would say.
I think this is a more general issue with circular dependencies in Spigot, so not a Slimefun issue I would say.
So all good to be closed here then?