Backpack dupe items

Question

Backpack dupe items

ybw0014 opened this issue 2 years ago · 10 comments

ybw0014 commented 2 years ago

❗ Checklist

I am using the official english version of Slimefun and did not modify the jar.
I am using an up to date "DEV" (not "RC") version of Slimefun.
I am aware that issues related to Slimefun addons need to be reported on their bug trackers and not here.
I searched for similar open issues and could not find an existing bug report on this.

📍 Description

Backpacks can be used to dupe items.

Two players, a backpack, and backpack upgrade materials are needed.

📑 Reproduction Steps

Player A holds a backpack in main hand, and a portable crafting table in off hand.
Player A opens a backpack, and put items that need to be duped (e.g. 64x diamonds).
Player A press F to switch backpack & portable, and switch back. (Not closing backpack)
Player A drops the backpack, without closing the backpack.
Player B picks up the backpack from Player A, upgrade it in enhanced crafting table.
Player B opens the backpack, gets the 64x diamonds.
Player A gets 64x diamonds, in total, 128x diamonds.

💡 Expected Behavior

The opened backpacks are closed.

📷 Screenshots / Videos

https://youtu.be/IFFCafxr7bQ

📜 Server Log

N/A

📂 `/error-reports/` folder

N/A

💻 Server Software

Paper

🎮 Minecraft Version

1.19.x

⭐ Slimefun version

DEV - 1027

🧭 Other plugins

No

Phoenix-Starlight · Answer 1 · 2022-10-08T05:52:18.000Z

Patience. This is an open-source project contributed to by volunteers.

…

On 10/7/22, J3fftw ***@***.***> wrote: You could temporarily disable it -- Reply to this email directly or view it on GitHub: #3664 (comment) You are receiving this because you are subscribed to this thread. Message ID: ***@***.***>

Phoenix-Starlight · Answer 2 · 2022-10-08T05:52:47.000Z

Also you will not lose backpack data if you were to disable usage. The data will remain but no one can make backpacks or use them.

…

On 10/7/22, Nova Star ***@***.***> wrote: Patience. This is an open-source project contributed to by volunteers. On 10/7/22, J3fftw ***@***.***> wrote: > You could temporarily disable it > > -- > Reply to this email directly or view it on GitHub: > #3664 (comment) > You are receiving this because you are subscribed to this thread. > > Message ID: ***@***.***>

SrMonsterYT · Answer 3 · 2022-10-08T15:10:49.000Z

You could temporarily disable it

ok thanks and sorry

TheBusyBiscuit · Answer 4 · 2022-09-29T10:39:34.000Z

Thanks for the detailed bug report!

The issue should be fixed within the latest commit.
Players should no longer be able to swap the backpack from hand to another while having the backpack open.
Additionally, a safeguard was added to close the backpack inventory before upgrading its size.

SrMonsterYT · Answer 5 · 2022-10-03T17:41:40.000Z

bug continues in version DEV - 1033 (git 5455fb0)

video: https://streamable.com/yzib9s

pump61 · Answer 6 · 2022-10-04T21:46:56.000Z

dupe is still working I can do it right now if I need to, in the video I show that I'm using version 1033

SrMonsterYT · Answer 7 · 2022-10-07T16:51:16.000Z

please fix this, people are abusing it, and if I remove it from my server I will lose a lot of items.

J3fftw1 · Answer 8 · 2022-10-07T16:53:54.000Z