Multi-Tool is not cancelling the block break event properly
SideLo98 opened this issue · 5 comments
❗ Checklist
- I am using the official english version of Slimefun and did not modify the jar.
- I am using an up to date "DEV" (not "RC") version of Slimefun.
- I am aware that issues related to Slimefun addons need to be reported on their bug trackers and not here.
- I searched for similar open issues and could not find an existing bug report on this.
📍 Description
While using multi-tool to harvest crops, mine/dig blocks etc to get paid for MoneyHunter's job the multitool prevents the block from breaking but somehow players still gets paid infinitely.
📑 Reproduction Steps
- grow any crop
- break it using any multi tool
- The crop will not break but still will drop money infinitely
💡 Expected Behavior
it should prevent the block break event (or some other technical term i dunno)
📷 Screenshots / Videos
📜 Server Log
not required
📂 /error-reports/ folder
no errors
💻 Server Software
Paper
🎮 Minecraft Version
1.19.x
⭐ Slimefun version
https://ibb.co/vjXn9Yg
https://postimg.cc/s1P1x1kf
🧭 Other plugins
MoneyHunters and NexEngine (dependency for MoneyHunters)
slimefun items don't drop money. thats another plugin interfering with slimefun
that's correct MoneyHunters plugin does the money drop but normally it should only pay when the block(sugar cane in this case) gets really broken/harvested. this happens with multi-tool in hand only
@Phoenix-Starlight This has nothing to do with dough.
@SideLo98
I had a look at this "MoneyHunters" plugin and the issue is pretty self-explaining.
They are listening to this event on the wrong priority: https://github.com/nulli0n/MoneyHunters-spigot/blob/master/Basic/src/main/java/su/nightexpress/moneyhunters/basic/manager/job/listener/JobListenerGeneric.java#L92
The event itself is not modified by the plugin, it only listens to the outcome of the event and should therefore run on the priority MONITOR, not HIGHEST.
This is not a Slimefun issue.