Issue with plugin Vehicles and probably more
Rokysek opened this issue · 22 comments
❗ Checklist
- I am using the official english version of Slimefun and did not modify the jar.
- I am using an up to date "DEV" (not "RC") version of Slimefun.
- I am aware that issues related to Slimefun addons need to be reported on their bug trackers and not here.
- I searched for similar open issues and could not find an existing bug report on this.
📍 Description
In Vehicles plugin, you can plant seeds using tractor. If you have Slimefun item that is placable (+more, tried it with machines, cargo, solar panels, backpacks) in your main hand, it plants a seed which after destroying drops the item that was in your hand. I asked Vehicles support and they found out that the error causing it is probably line 80. I am sending some messages from him:
(Server is running on Waterfall - Yatopia)
📑 Reproduction Steps
- Ride a tractor
- Put in seeds
- Put the Slimefun item in your main hand
- Ride over farmland
- Destroy the seed (doesn’t have to be grown)
💡 Expected Behavior
It shouldn’t interfere with what you are planting, it should plant the item that is in the vehicle trunk.
📷 Screenshots / Videos
https://medal.tv/games/minecraft/clips/UYm6TSvGIMsVI/d1337wv7pVSz?invite=cr-MSxwTEIsMjc4MTU2MzIs
📜 Server Log
No response
📂 /error-reports/ folder
No response
💻 Server Software
Other (please specify in your description)
🎮 Minecraft Version
1.18.x
⭐ Slimefun version
🧭 Other plugins
Vehicles - https://www.spigotmc.org/resources/%E2%9C%88%EF%B8%8Fvehicles-no-resourcepacks-needed.12446/
since vehicles has stated to Alessio that this bug will not be able to be fixed, do we need to keep this open? is there any chance we are able to fix the issue?
We should be able to fix it from our side so yes keep it open it’s still a bug
We can't
Message 7 for the full run down we went over a numerous amount of things, the issue was on their side, idk if they've pushed the patch that was figured out or not
There is still a bug, even if its a non fix from our side we should keep it open to link future reports to
Oh for sure! Not against keeping the issue open, we tested a fix on their end (and it worked) sometime in January, going to assume they haven't pushed it yet?
when Alessio was working with them, it was a fundamental difference in how certain parts of the code was handled, and neither side could change, iirc. the solution he came up with was to disable tractors in vehicles
when Alessio was working with them, it was a fundamental difference in how certain parts of the code was handled, and neither side could change, iirc. the solution he came up with was to disable tractors in vehicles
I was working with him on it, we did find a proper fix, they were handling an event incorrectly.
I've made a simple fix for it in my fork. Simply ignore the event if the player is in a vehicle and the plugin is enabled.
The fix is ready and they have been notified, they just went radio silence on their end for a bit. Apparently soon ™️ it will be out
Would love to see an update on this, given that it seems quite simple to fix =D
If it is simple feel free to make a Pull request solving the issue. 😉
