Elemental Staff - Fire should not be usable in disenchanters
rukshan2004lk opened this issue · 11 comments
❗ Checklist
- I am using the official english version of Slimefun and did not modify the jar.
- I am using an up to date "DEV" (not "RC") version of Slimefun.
- I am aware that issues related to Slimefun addons need to be reported on their bug trackers and not here.
- I searched for similar open issues and could not find an existing bug report on this.
📍 Description
this is a bug regarding Elemental Staff - Fire
📑 Reproduction Steps
if the bug start when player put stacks
💡 Expected Behavior
i have suggestion add only 1 stick per time
📷 Screenshots / Videos
https://www.youtube.com/watch?v=A6NEFDFA2Qw
📜 Server Log
No response
📂 /error-reports/
folder
No response
💻 Server Software
Purpur
🎮 Minecraft Version
1.19.x
⭐ Slimefun version
Dev - 1043
🧭 Other plugins
No response
Yes, it is fixable. The elemental staves would just need to be marked as disenchantable. Looks like that was a simple oversight.
This issue is related to #3341. It’s not the same issue but it has the same underlying problem.
can you disable not place cargo node to dis enchanter if you do that bug will be fix because bug happen when book go through cargo node
Biscuit, I think this may be related to #3379 It has the same characteristics.
@Boomer-1
It is not. In the video you can clearly see that the Auto Disenchanter treats the elemental staff (which has Fire Aspect) like a tool, takes its enchantment and applies it to a book.
Normally, this should not be able to work as Fire Aspect 5 is not obtainable in survival.
To prevent this, every item has a boolean isDisenchantable
which is set to false for any item that could be exploited like this. However, the elemental staff was somehow forgotten, resulting in this exploit.
Cargo or not, you can obtain Fire Aspect V in survival through this exploit. Only way to prevent this is to set it to false.
the fire aspect I don't see that as the issue, since you can already make that with slimefun. but what I'm hearing, is the staff needs to be marked with the tag you mentioned so it isn't treated as a tool, correct?
the other thing i saw in the video that brought up the cargo issue, is those staffs that were disenchanted, became re-enchanted with the fire aspect 5 after going thru cargo. that's why i linked 3379
that doesn't fix the problem, and will have thousands of people complaining that they can no longer automate enchantments. the actual issue has to be fixed.
Biscuit, I think this may be related to #3379 It has the same characteristics.