Soulbound items disappear when restarting the server mid-deathscreen
KiinoOFC opened this issue · 16 comments
❗ Checklist
- I am using the official english version of Slimefun and did not modify the jar.
- I am using an up to date "DEV" (not "RC") version of Slimefun.
- I am aware that issues related to Slimefun addons need to be reported on their bug trackers and not here.
- I searched for similar open issues and could not find an existing bug report on this.
📍 Description
When a player dies with Soulbound items. After restarting the server, the items disappear
📑 Reproduction Steps
- Have items with Soulbound
- Then you die
- Restart the server
- Join the server
- Checks if Soulbound items are there
💡 Expected Behavior
Soulbound items do not disappear
📷 Screenshots / Videos
📜 Server Log
no errors to log
📂 /error-reports/
folder
no errors to folder
💻 Server Software
Paper
🎮 Minecraft Version
1.17.x
⭐ Slimefun version
Paper git-Paper-411 (MC: 1.17.1)
Slimefun DEV - 1043 (git 4bfc4f0)
Metrics-Module #28
Java 17
🧭 Other plugins
No response
@Boomer-1 i would assume this also happens when the player disconnects and joins back after he died?
ok. i think i figured it out. you're shutting your server down before the player clicks respawn. that's the only way i've been able to do it. so in the extreme possibility that the player dies in that millisecond, and they can't click respawn it disappears. in that brief moment between death and the server restart, the event cant fire. iirc, it fires on the click of respawn. because the data can't be saved thru a restart. not sure if there's a fix to that or not. Dev's will have to look into it.
what about storing it as NBT on the player? in the .dat
well, you have at least one based on the picture you provided of your inventory. something you've installed, in the server or the client is interfering. without all the info we can't help
I managed to fix my OBS, maybe this will help
2023-02-20-23-17-31_ydqhLUo4.mp4
2023-02-20.23-19-22.mp4
and the server was created from scratch to test this, just with the addition of slimefun
with the exact same server, minecraft version and slimefun version i cannot recreate it. I've tried netherite armor, diamond armor and it stays everytime. try removing the pack and do it again
ok. i think i figured it out. you're shutting your server down before the player clicks respawn. that's the only way i've been able to do it. so in the extreme possibility that the player dies in that millisecond, and they can't click respawn it disappears. in that brief moment between death and the server restart, the event cant fire. iirc, it fires on the click of respawn. because the data can't be saved thru a restart. not sure if there's a fix to that or not. Dev's will have to look into it.
So whomever wants to look into this, the key here is the server shuts down before the player clicks respawn. that key moment is the issue